Support rollback nodes in KeyValueCommitting.submissionOutputs #9512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed on Slack overapproximating and thereby not treating nodes under a rollback special seems like a good first step and matches what we do for transient contracts. changelog_begin changelog_end
cocreature
requested review from
fabiotudone-da,
gerolf-da and
miklos-da
as code owners
ghost
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
The tests look sensible (though I'd appreciate it if @fabiotudone-da would also take a look).
I have some suggestions on style, but not on the substance.
.../src/test/suite/scala/com/daml/ledger/participant/state/kvutils/KeyValueCommittingSpec.scala
Outdated
Show resolved
Hide resolved
.../src/test/suite/scala/com/daml/ledger/participant/state/kvutils/KeyValueCommittingSpec.scala
Outdated
Show resolved
Hide resolved
.../src/test/suite/scala/com/daml/ledger/participant/state/kvutils/KeyValueCommittingSpec.scala
Show resolved
Hide resolved
changelog_begin changelog_end
changelog_begin changelog_end
miklos-da
approved these changes
Apr 27, 2021
...te/kvutils/src/main/scala/com/daml/ledger/participant/state/kvutils/KeyValueCommitting.scala
Outdated
Show resolved
Hide resolved
.../src/test/suite/scala/com/daml/ledger/participant/state/kvutils/KeyValueCommittingSpec.scala
Outdated
Show resolved
Hide resolved
.../src/test/suite/scala/com/daml/ledger/participant/state/kvutils/KeyValueCommittingSpec.scala
Outdated
Show resolved
Hide resolved
.../src/test/suite/scala/com/daml/ledger/participant/state/kvutils/KeyValueCommittingSpec.scala
Outdated
Show resolved
Hide resolved
.../src/test/suite/scala/com/daml/ledger/participant/state/kvutils/KeyValueCommittingSpec.scala
Outdated
Show resolved
Hide resolved
.../src/test/suite/scala/com/daml/ledger/participant/state/kvutils/KeyValueCommittingSpec.scala
Show resolved
Hide resolved
Co-authored-by: Miklos <[email protected]>
fabiotudone-da
approved these changes
Apr 27, 2021
...te/kvutils/src/main/scala/com/daml/ledger/participant/state/kvutils/KeyValueCommitting.scala
Outdated
Show resolved
Hide resolved
…r/participant/state/kvutils/KeyValueCommitting.scala Co-authored-by: fabiotudone-da <[email protected]>
changelog_begin changelog_end
azure-pipelines bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @nickchapman-da is in charge of this release. Commit log: ``` e1e878a Simplify opt-in/out of Oracle when building (#9515) d761853 KVL-874 Add unit tests for Telemetry (#9500) c567680 Support rollback nodes in PostCommitValidation (#9501) a335ee8 Support rollback nodes in KeyValueCommitting.submissionOutputs (#9512) 8747b3d Support rollback nodes in TransactionIndexing (#9506) c4cf3c9 kvutils: Log a missing input state warning without the stack trace. (#9513) 4e712a0 add oracle option for json-api perf runner (#9492) 8cd3658 Switch to an environment variable for enabling Oracle tests. (#9511) e39c20e update GPG public key (#9488) 782109d update LATEST (#9508) 3e66611 Nest stakeholders in contracts table as JSON arrays (#9484) aecdc2a update NOTICES file (#9507) ``` Changelog: ``` - [JSON-API Perf] ``--query-store-index=postgres`` must be passed to select PostgreSQL query store performance testing; ``true`` and ``yes`` are no longer supported. See `issue #9492 <https://github.com/digital-asset/daml/pull/9492>`__. ``` CHANGELOG_BEGIN CHANGELOG_END
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Slack overapproximating and thereby not treating nodes
under a rollback special seems like a good first step and matches what
we do for transient contracts.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.