Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all Api...Service classes to Sandbox package #3995

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Move all Api...Service classes to Sandbox package #3995

merged 1 commit into from
Jan 9, 2020

Conversation

stefanobaghino-da
Copy link
Contributor

@stefanobaghino-da stefanobaghino-da commented Jan 9, 2020 •
edited
Loading

This is done to restrict the usage of NamedLoggerFactory and most usages of MetricsRegistry
to a single Bazel package, thus allowing a possible replacement to not have to become a
dependency of multiple packages.

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@stefanobaghino-da
Move all Api...Service classes to Sandbox package
7c9570f 
This is done to restrict the usage of NamedLoggerFactory and most usages of MetricsRegistry
to a single Bazel package, thus allowing a possible replacement to not have to become a
dependency of multiple packages.

CHANGELOG_BEGIN
CHANGELOG_END
rautenrieth-da
rautenrieth-da approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@rautenrieth-da rautenrieth-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code cleanups along with the move.

@stefanobaghino-da
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@stefanobaghino-da
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@mergify mergify bot merged commit 12d7ad8 into master Jan 9, 2020
@mergify mergify bot deleted the move-api-classes-to-sandbox branch January 9, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rautenrieth-da rautenrieth-da rautenrieth-da approved these changes

@gerolf-da gerolf-da Awaiting requested review from gerolf-da

@SamirTalwar SamirTalwar Awaiting requested review from SamirTalwar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanobaghino-da @rautenrieth-da