Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update canton to 20241020.14357.va37ef963 #20137

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

azure-pipelines[bot]
Copy link
Contributor

tell-slack: canton

@atriantafyllos-da
Copy link
Contributor

/azp run

Copy link
Contributor Author

Azure Pipelines successfully started running 1 pipeline(s).

atriantafyllos-da and others added 2 commits October 21, 2024 13:04
* Drop unused NewVariant errors, add NotAtEnd errors, improve messages

* Refactor error printing slightly

* Update error message expectations in lsp-tests & damlc-upgrades

* Add metadata to pkg IDs & drop upgrading/upgraded in upgrade err msgs

* Replace "Variant" with "Constructor" where appropriate

* lint

* Adjust filepaths, expectations for Variant -> Constructor rename

* Fixes for field names and test expectations given added metadata

* Increase grpc message max log length

* lint

* Move & rename PkgIdWithMeta, make name/version non-optional

* Use shared variable instead of calling PkgIdWithNameAndVersion thrice

* lint
@atriantafyllos-da
Copy link
Contributor

/azp run

Copy link
Contributor Author

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@oliverse-da oliverse-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you, @atriantafyllos-da

@oliverse-da oliverse-da merged commit 3f43ae4 into main Oct 21, 2024
15 checks passed
@oliverse-da oliverse-da deleted the main-canton-update-20241020.14357.va37ef963 branch October 21, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants