Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ListUsersRequest #14943

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Added ListUsersRequest #14943

merged 3 commits into from
Sep 7, 2022

Conversation

chunlokling-da
Copy link
Contributor

@chunlokling-da chunlokling-da commented Sep 6, 2022 •
edited
Loading

fixes #14165

CHANGELOG_BEGIN
Allow to list all users by providing page token and page size in the Java bindings
CHANGELOG_END

@chunlokling-da
Added ListUsersRequest
d57eb9a 
CHANGELOG_BEGIN
CHANGELOG_END
@chunlokling-da chunlokling-da linked an issue Sep 6, 2022 that may be closed by this pull request
Allow to list all users in the Java bindings #14165
Closed
@chunlokling-da
Add code change
d69aa2c 
CHANGELOG_BEGIN
Allow to list all users by providing page token and page size in the Java bindings
CHANGELOG_END
@chunlokling-da chunlokling-da self-assigned this Sep 6, 2022
@chunlokling-da chunlokling-da added component/java-ecosystem Java development experience team/ledger-clients Related to the Ledger Clients team's components. labels Sep 6, 2022
@chunlokling-da chunlokling-da marked this pull request as draft September 6, 2022 11:17
ray-roestenburg-da
ray-roestenburg-da reviewed Sep 6, 2022
View reviewed changes
Copy link
Contributor

@ray-roestenburg-da ray-roestenburg-da left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, can you add a test?

@chunlokling-da chunlokling-da marked this pull request as ready for review September 7, 2022 09:22
@chunlokling-da
Copy link
Contributor Author

Test cases added

@chunlokling-da chunlokling-da merged commit a516be7 into main Sep 7, 2022
@chunlokling-da chunlokling-da deleted the 14165-list-all-users-pagination branch September 7, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray-roestenburg-da ray-roestenburg-da ray-roestenburg-da approved these changes

Assignees

@chunlokling-da chunlokling-da

Labels
component/java-ecosystem Java development experience team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to list all users in the Java bindings
2 participants
@chunlokling-da @ray-roestenburg-da