Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

choice name overloading in lf/interface #13938

Merged
merged 31 commits into from
May 31, 2022
Merged

choice name overloading in lf/interface #13938

merged 31 commits into from
May 31, 2022

Conversation

S11001001
Copy link
Contributor

Fixes #13918.

@S11001001 S11001001 added component/daml-lf DAML-LF team/ledger-clients Related to the Ledger Clients team's components. labels May 19, 2022
@S11001001 S11001001 self-assigned this May 19, 2022
S11001001 added 20 commits May 23, 2022 10:10
@S11001001
stub out TemplateChoices test
56baad0
@S11001001
Merge commit '1343dcd827012a334a6378a9d552c2c16df02e4f' into 13918-lf…
d0db5be 
…-iface-choice-overload
@S11001001
make TemplateChoices test compile
8f14792
@S11001001
replacing DefTemplate choices
ae412c5
@S11001001
Merge commit '49a5474232b59a8f438042c80e487c92eb3ef819' into 13918-lf…
6775a71 
…-iface-choice-overload
@S11001001
adapt DefTemplate
0eae9a7
@S11001001
read TemplateChoices from ast
6492abc
@S11001001
report a bigger error, with a more helpful stringification
f88df38
@S11001001
fix infinite loop
3f5ed0d
@S11001001
if any resolutions fail in EnvironmentInterface, discard the template…
9c22a8e 
…'s resolution
@S11001001
if any resolutions fail in Interface, discard the remaining unresolved
6db12ca
@S11001001
interface tests compile with the new choices structure
52cb05a
@S11001001
fix choice resolution checks
30c62cb
@S11001001
simple downstream signatures, a shim approach for Java codegen
68bd517
@S11001001
move assumeOneChoicePerName to assumeNoOverloadedChoices method
ea4a2d9
@S11001001
navigator, java, scala codegen compile
e2322ed
@S11001001
script runner compiles
b577087
@S11001001
no changelog
5755985 
CHANGELOG_BEGIN
CHANGELOG_END
@S11001001
Merge commit 'd3264236ba9e5ebef6f44731949114a2baef5d4a' into 13918-lf…
492d8f0 
…-iface-choice-overload
@S11001001
change issue # for script
f4b43d5
@S11001001 S11001001 mentioned this pull request May 24, 2022
Open
3 tasks
@S11001001 S11001001 marked this pull request as ready for review May 24, 2022 18:19
@S11001001 S11001001 requested review from cocreature and ray-roestenburg-da and removed request for remyhaemmerle-da and ray-roestenburg-da May 24, 2022 18:20
remyhaemmerle-da
remyhaemmerle-da approved these changes May 30, 2022
View reviewed changes
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks.

@S11001001 S11001001 merged commit 96a6fe6 into main May 31, 2022
@S11001001 S11001001 deleted the 13918-lf-iface-choice-overload branch May 31, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyhaemmerle-da remyhaemmerle-da remyhaemmerle-da approved these changes

@cocreature cocreature Awaiting requested review from cocreature

@ray-roestenburg-da ray-roestenburg-da Awaiting requested review from ray-roestenburg-da

Assignees

@S11001001 S11001001

Labels
component/daml-lf DAML-LF team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support interface inheritance of same-named choices in LF interface library
2 participants
@S11001001 @remyhaemmerle-da