-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-db sandbox-on-x conformance tests [DPP-802] #12585
Add multi-db sandbox-on-x conformance tests [DPP-802] #12585
Conversation
...er/sandbox-on-x/src/test/lib/scala/com/daml/ledger/sandbox/MainWithEphemeralOracleUser.scala
Outdated
Show resolved
Hide resolved
@nmarton-da Oracle tests are timeouting |
1374d6e
to
6a4344f
Compare
ledger/sandbox-on-x/BUILD.bazel
Outdated
main_class = "com.daml.ledger.sandbox.MainWithEphemeralPostgresql", | ||
visibility = ["//visibility:public"], | ||
runtime_deps = [ | ||
"@maven//:com_oracle_database_jdbc_ojdbc8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is Oracle driver needed for Postgres?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it definitely does not 👍
funny thing we do not need this for oracle neither: these deps are creeping in as build deps already, removed that as well
6a4344f
to
6d5a608
Compare
|
6d5a608
to
60b6801
Compare
@meiersi-da @tudor-da @mziolekda
Since we already have a story for the first and second (and actually only one of them would fix the issue here), I propose to put this on hold until either of those are done, which will solve the flakiness here. Regarding the last point ("package deduplication") just wanted to make you aware of this difference between sandbox-on-x and kv ledgers (or at least ledger-on-sql): not sure what is expected here. FYI since in canton Oracle tests we observed similar errors, I guess the canton ledger is also not doing "package deduplication". |
Thanks @nmarton-da . Let's look at how to index package and .dar uploads together with @andreaslochbihler-da and @rgugliel-da as part of the storage architecture revision. We definitely want to store the package contents at most once, as they can be large. However, we might want index them being made available for interpretation multiple times. |
* Enhances SandboxOnXRunner with manipulateConfig * Adds Postgres and Oracle conformance test runner binaries * Adapts BUILD.bazel changelog_begin changelog_end
60b6801
to
ecdef63
Compare
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGIN
andCHANGELOG_END
tagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.