Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.11.3-snapshot.20211123.6448.0.c679b4ab #11981

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

stefanobaghino-da
Copy link
Contributor

@stefanobaghino-da stefanobaghino-da commented Dec 6, 2021

Changelog


- [JSON-API] added metrics to separately track:
    - time taken to update query-store ACS (from ledger)
    - lookup times for the query store

[HTTP/JSON API]
- metrics reporting can now be chosen via the command line option --metrics-reporter (currently hidden), valid options are console, csv://, graphite:// and prometheus://
- metrics reporting interval can also now be chosen via a command line option --metrics-reporting-interval (currently hidden)

- [Ledger HTTP Json Service] Logging output can now be in JSON either via providing the cli option `--log-encoder json` or via setting the env var `LOG_FORMAT_JSON=true`

[HTTP-JSON]
- fixed that json log output could not be enabled via cli options except via usage of env vars

- [Ledger HTTP Json service] Logging can now be configured via the `--log-level` cli argument. Valid values are `error`, `warn`, `info` (default), `debug`, `trace`

- [Ledger HTTP Json Service] Logging now also tells service name if log level was changed.

http-json:
- add contextual id as logging context to distinguish different application runs in logs
- add request id as logging context to distinguish different http requests within an application run
- add for non-static endpoints trace logs which show how long processing it took in ns

- [JSON API] Fix an error where transactions that delete a large
  number of contracts resulted in stackoverflows with the PostgreSQL
  backend and database errors with Oracle.

- [JSON API] While updating the contract table for a query, if the DB appears to be slow,
  JSON API will slow down its own inserts and deletes at some point rather than construct
  ever-larger INSERT and DELETE batch commands.
  See `issue #11589 <https://github.com/digital-asset/daml/pull/11589>`__.
Backport of Hikari connection pool for 1.11.x plus addition of configurable connection pool properties to jdbcConfig string, the properties are listed below
poolSize -- specifies the max pool size for the database connection pool
minIdle -- specifies the min idle connections for database connection pool
connectionTimeout -- long value, specifies the connection timeout for database connection pool
idleTimeout -- long value, specifies the idle timeout for the database connection pool
[Ledger API] Retry the interpretation of a command in case of a race
with other transactions. This fix drastically reduces the likelihood of the error
"Could not find a suitable ledger time after 0 retries".
For every update in the index db log the full context at the INFO level.
[Integration Kit] The state of the participant indexer can now be checked via the GRPC health endpoint

Commits

c679b4ab23 [1.11.x] Metrics for investigating  json api performance (#11769)
437c3d4639 Bump Windows postgres (#11806)
382168b7f0 Add metrics to the http json service (#9923) (#11768)
b7fc305427 [Backport] Add cli option & system property to enable json only logging for the json api (#11717)
17cacb05f1 [Backport] Add logging command line option to ledger http service (#9581) (#11699)
56531e8610 Backport: Support deletion of a large number of contracts (#11646)
6bf19fce82 Backport: limit contract insertion/deletion batching on backpressure (#11647)
eed4ad32b7 Backport signing tool changes (#11651)
ee7547ed88 [JSON-API] Backport of connection pool for 1.11.x , configurable db options needs forward porting (#11615)
632ba5a7b3 Backport: Avoid collision in execution log postfix (#11644)
cf4f1a1d8f Backport: add tar to dev-env (#10173) (#11636)
b78fa8c4a3 Backport: Restart the submission interpretation in case of a race [DPP-737] (#11578)
5c3220d2db Fix build of release/1.11.x branch (#11582)
cce7c79ec5 Log context of all updates written to the database (#10057)
a9d0473473 Adds Indexer state to GRPC health checks [DPP-434] (#9951) (#9961)

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Changelog
---------

```

- [JSON-API] added metrics to separately track:
    - time taken to update query-store ACS (from ledger)
    - lookup times for the query store

[HTTP/JSON API]
- metrics reporting can now be chosen via the command line option --metrics-reporter (currently hidden), valid options are console, csv://, graphite:// and prometheus://
- metrics reporting interval can also now be chosen via a command line option --metrics-reporting-interval (currently hidden)

- [Ledger HTTP Json Service] Logging output can now be in JSON either via providing the cli option `--log-encoder json` or via setting the env var `LOG_FORMAT_JSON=true`

[HTTP-JSON]
- fixed that json log output could not be enabled via cli options except via usage of env vars

- [Ledger HTTP Json service] Logging can now be configured via the `--log-level` cli argument. Valid values are `error`, `warn`, `info` (default), `debug`, `trace`

- [Ledger HTTP Json Service] Logging now also tells service name if log level was changed.

http-json:
- add contextual id as logging context to distinguish different application runs in logs
- add request id as logging context to distinguish different http requests within an application run
- add for non-static endpoints trace logs which show how long processing it took in ns

- [JSON API] Fix an error where transactions that delete a large
  number of contracts resulted in stackoverflows with the PostgreSQL
  backend and database errors with Oracle.

- [JSON API] While updating the contract table for a query, if the DB appears to be slow,
  JSON API will slow down its own inserts and deletes at some point rather than construct
  ever-larger INSERT and DELETE batch commands.
  See `issue #11589 <https://github.com/digital-asset/daml/pull/11589>`__.
Backport of Hikari connection pool for 1.11.x plus addition of configurable connection pool properties to jdbcConfig string, the properties are listed below
poolSize -- specifies the max pool size for the database connection pool
minIdle -- specifies the min idle connections for database connection pool
connectionTimeout -- long value, specifies the connection timeout for database connection pool
idleTimeout -- long value, specifies the idle timeout for the database connection pool
[Ledger API] Retry the interpretation of a command in case of a race
with other transactions. This fix drastically reduces the likelihood of the error
"Could not find a suitable ledger time after 0 retries".
For every update in the index db log the full context at the INFO level.
[Integration Kit] The state of the participant indexer can now be checked via the GRPC health endpoint
```

Commits
-------

```
c679b4a [1.11.x] Metrics for investigating  json api performance (#11769)
437c3d4 Bump Windows postgres (#11806)
382168b Add metrics to the http json service (#9923) (#11768)
b7fc305 [Backport] Add cli option & system property to enable json only logging for the json api (#11717)
17cacb0 [Backport] Add logging command line option to ledger http service (#9581) (#11699)
56531e8 Backport: Support deletion of a large number of contracts (#11646)
6bf19fc Backport: limit contract insertion/deletion batching on backpressure (#11647)
eed4ad3 Backport signing tool changes (#11651)
ee7547e [JSON-API] Backport of connection pool for 1.11.x , configurable db options needs forward porting (#11615)
632ba5a Backport: Avoid collision in execution log postfix (#11644)
cf4f1a1 Backport: add tar to dev-env (#10173) (#11636)
b78fa8c Backport: Restart the submission interpretation in case of a race [DPP-737] (#11578)
5c3220d Fix build of release/1.11.x branch (#11582)
cce7c79 Log context of all updates written to the database (#10057)
a9d0473 Adds Indexer state to GRPC health checks [DPP-434] (#9951) (#9961)
```

changelog_begin
changelog_end
@stefanobaghino-da stefanobaghino-da merged commit 8290c12 into main Dec 6, 2021
@stefanobaghino-da stefanobaghino-da deleted the release-1.11.3-snapshot branch December 6, 2021 16:53
@stefanobaghino-da
Copy link
Contributor Author

Manual tests passed on Windows.

@stefanobaghino-da
Copy link
Contributor Author

Manual tests passed on Linux.

stefanobaghino-da added a commit that referenced this pull request Dec 7, 2021
changelog_begin
changelog_end

The snapshot was released with #11981
stefanobaghino-da added a commit that referenced this pull request Dec 7, 2021
changelog_begin
changelog_end

The snapshot was released with #11981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants