-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional rights and clarifications to user management API #11908
Add additional rights and clarifications to user management API #11908
Conversation
963374b
to
cf6516f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meiersi-da given that the extra rights are out of scope now iiuc should this be updated? (and merged so we have the same base to work against)
Agreed @moritzkiefer-da . I've just found that we already have |
Note that while we have this internally, we currently do not expose this in any form to our users. So we may still want to be cautious in making this part of our public APi. |
CHANGELOG_BEGIN CHANGELOG_END Breaks-protobuf: true
c60cd5c
to
ac23650
Compare
I'm inclined to expose it as it is
That said, I might be overlooking things. So what actions do you think we need to take before exposing this? |
Hmm... now having written that I get the rubber-duck effect: it seems that @bame-da what is your opinion? |
I’m not super strongly opposed to exposing it but it doesn’t seem necessary for 2.0 and I have concerns similar to the ones you mentioned above (encouraging various antipatterns). Adding it later seems fully backwards compatible so we can add it once we’re confident it’s a good idea. |
Thanks @cocreature for the valuable push-back. I've removed the xxxAnyRights |
thanks! and just to be clear I’m happy to revisit this outside of the 2.0 scope |
Addresses: learning from design doc and review comments from #11818 that were added after merging; concretely
CanActAsAnyParty
andCanReadAsAnyParty
rightsprimary_party
optional for special usersDeleteUserResponse
FYI: @da-tanabe @bame-da @cocreature @gerolf-da @stefanobaghino-da @adriaanm-da @nmarton-da
Pull Request Checklist
CHANGELOG_BEGIN
andCHANGELOG_END
tagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.