Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write exception reports into the log-file in case of SSL misconfiguration [DPP-759] #11776

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Write exception reports into the log-file in case of SSL misconfiguration [DPP-759] #11776

merged 1 commit into from
Nov 18, 2021

Conversation

mziolekda
Copy link
Contributor

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@mziolekda mziolekda requested a review from a team as a code owner November 18, 2021 13:54
tudor-da
tudor-da reviewed Nov 18, 2021
View reviewed changes
ledger/participant-integration-api/src/main/scala/platform/apiserver/LedgerApiServer.scala
@@ -65,6 +65,11 @@ private[daml] final class LedgerApiServer(
override def servicesClosed(): Future[Unit] =
servicesClosedPromise.future
}
}).transformWith {
case Failure(ex) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to log explicitly here? Isn't the Resource going to bubble up the failure all the way through the chain?

Copy link
Contributor

@tudor-da tudor-da Nov 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here is how they bubble up at the edge. Unless the exception is a SuppressedStartupException, I don't see how it would skip logging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it skips because of timing, the log is protracted until the very end of the shutdown and is not printed when something else pops up in between

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not purely theoretical, I have been able to reproduce it many times

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it skips because of timing, the log is protracted until the very end of the shutdown and is not printed when something else pops up in between

I see. The possibility of skipping failure logs on application startup is not ideal so we should revisit this part at some point since we perform a lot of startup operation in these resources. Nice findings. LGTM 👍

tudor-da
tudor-da approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@tudor-da tudor-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you deem it to bring value

@mziolekda mziolekda enabled auto-merge (squash) November 18, 2021 14:31
@mziolekda mziolekda merged commit a9754fe into main Nov 18, 2021
@mziolekda mziolekda deleted the mziolek/dpp-759-exception-reports-on-ssl-misconfiguration branch November 18, 2021 18:26
mziolekda added a commit that referenced this pull request Nov 19, 2021
@mziolekda
Write exception reports into the logfile in case of ssl misconfigurat…
1760e0c 
…ion (#11776)

CHANGELOG_BEGIN
CHANGELOG_END
mziolekda added a commit that referenced this pull request Nov 22, 2021
@mziolekda
Write exception reports into the logfile in case of ssl misconfigurat…
e510d1c 
…ion (#11776)

CHANGELOG_BEGIN
CHANGELOG_END
mziolekda added a commit that referenced this pull request Nov 22, 2021
@mziolekda
Write exception reports into the logfile in case of ssl misconfigurat…
97505f6 
…ion (#11776)

CHANGELOG_BEGIN
CHANGELOG_END
mziolekda added a commit that referenced this pull request Nov 22, 2021
@mziolekda
Write exception reports into the logfile in case of ssl misconfigurat…
2d263e8 
…ion (#11776) (#11788)

CHANGELOG_BEGIN
CHANGELOG_END
azure-pipelines bot pushed a commit that referenced this pull request Nov 24, 2021
release 1.18.0-snapshot.20211123.8463.0.bd2a6852
81c75d4 
This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@nickchapman-da is in charge of this release.

Commit log:
```
bd2a685 Make ACS reader parameters configurable (#11732)
329e609 [Self-service error codes] Group explanations (#11715)
32e9c4b Bump go rules (#11829)
6df7af7 update compat versions for 1.18.0-snapshot.20211117.8399.0.a05a40ae (#11743)
9461702 [DPP-673][Self-service error codes] Split one narrow migration table into multiple narrower ones to fit in the generated pdf's pages. (#11803)
5519184 [DPP-673][Self-service error-codes] Generate error code directory compatible with both pdf and html docs (#11794)
5a2c070 Skip append-only migration tests on each PR (#11816)
e6c8229 port #11798 documentation changes to json-api HTTP codes documentation (#11823)
1610d97 LF: parsing interface primitives (#11825)
f2aa09c Allow encoded server key files to be in base64 [DPP-761] (#11796)
cc3f551 update NOTICES file (#11824)
1bfcbc9 Refactoring for Canton compatibility on PackageServiceErrors (#11812)
c4b6a17 [Self-service error codes] Update existing error code references [DPP-593] (#11798)
addb2ed Drop Scala 2.13 version guards from Bazel definitions (#11819)
5785bbf Drop LF < 1.14 from supported damlc output versions (#11701)
ae8391e LF Parser: handle interface (#11797)
faddba4 Increase range for excluded snapshots in compatilbility tests (#11802)
f8933d1 Make lookupTemplateChoice return only choices in the template. (#11808)
3e0ac71 update NOTICES file (#11801)
8e31e8e [Self-service error codes] Enabled by default [DPP-691] (#11685)
ab520fb Fix es (#11784)
350ad98 Bump Windows postgres (#11804)
2d60ae8 update NOTICES file (#11799)
2d9ee20 [ledger-api-client] - Do not account for deduplication_time as timeout [KVL-1172] (#11791)
f334861 LF: Simplify LF Syntax (#11795)
cbe9c92 LF: Clean up Ast (#11786)
25e5bbb kvutils - Removed unused setting from conformance tests [KVL-1174] (#11785)
cd52f13 Remove `@aherrmann-da` from `CODEOWNERS` (#11792)
9bb12d0 update NOTICES file (#11787)
d23d113 Restructure interface desugaring (#11555)
1bb2fc2  LF: Simplify transaction versionning for interface (#11744)
4b59c57 Move select DB logic to JVM [DPP-760] (#11777)
5fb5784 Limit the number of parallel Bazel actions (#11779)
a9754fe Write exception reports into the logfile in case of ssl misconfiguration (#11776)
4a8e110 Add missing export of deleteBy from DA.NonEmpty (#11716)
51f646c Add engine tests for interfaces. (#11773)
ac57355 Drop Scala 2.12 compatibility layer from //daml-lf/data (#11758)
3b5f8a7 Remove precondition field from TemplateImplements (#11763)
2e789dd [DPP-417][Self-service error codes][Docs] Add more complete information for forking gRPC status codes. (#11739)
4ebdaf5 kvutils - Deprecate deduplicate_until [kvl-1174] (#11765)
f5a6302 [participant-integration-api] - Use internal CommandCompletionService [KVL-1172] (#11741)
39a38d3 Update to Java 11 (#11512)
91b4fb9 Backport: Skip protobuf compatibility check for PRs to non-main (#11772)
a3556a5 Retry release signature checks (#11771)
8f458d8 [ledger-api] Include the completion offset in the command_service.proto responses [KVL-1171] (#11658)
e891180 participant-state: Remove the v1 API. (#11553)
869b805 Bump sandbox acquisition timeout of trigger service tests to 1m (#11764)
4106222 Fix docs regarding deduplication periods [KVL-1194] (#11738)
186ba10 Fix missing encoding of nested maps in typescript bindings (#11746)
dd88ba2 kvutils - Backwards looking command deduplication [KVL-1174] (#11634)
43438c6 sandbox: Remove PostgreSQL conformance tests. (#11434)
b0a1bf7 More missing error codes (#11749)
3366413 Delete empty scala test library (#11747)
85979b3 Upgrade to Postgres 10 (#11751)
39c5966 Drop aherrman-da from release rotation (#11756)
c8ace8b Factor kind projector target into a variable (#11759)
e78bfc7 update NOTICES file (#11757)
fa76631 Drop 2.12 versioned_scala_deps (#11748)
c77e150 [JSON-API] ContractDao JMH benchmarks against PG (#11718)
d60cf70 rotate release duty after 1.18.0-snapshot.20211116.8395.0.ccbf7140 (#11734)
bb19c0d Drop Scala 2.12 support (#11619)
c2d4ea4 Add separate commands for create/fetch/exercise by template/interface. (#11724)
7e4acf9 link to doc detailing gRPC-to-HTTP code mapping (#11742)
7974427 release 1.18.0-snapshot.20211117.8399.0.a05a40ae (#11740)
```
Changelog:
```

- [Daml Compiler] Damlc can only produce Daml-LF 1.14 or
  newer. Passing aynthing older to `--target` is an error. If you
  need to produce older versions, use an older SDK.

[Ledger API Specification] The Ledger API returns enriched error codes (see https://docs.daml.com/error-codes/self-service/index.html)
For backwards-compatibility, a new API flag `--use-pre-1.18-error-codes` is introduced for preserving the legacy behavior for
clients that want to migrate incrementally to the changed gRPC status code responses and error details format.
ledger-api-client - The default command tracking timeout is no longer influenced by the deprecated deduplication_time as a deduplication period. Previously if no timeout was being set in the command and deduplication_time was set as the deduplication period then the command tracking timeout was the minimum between the deduplication_time and max tracking timeout.
[ledger-api] - Include the completion offset in the responses from the command_service.proto
- [Integration Kit] v1 of the participant state API is no longer
  supported. You will need to upgrade to v2.

- [Typescript Bindings] Fix an issue where nested maps did not get
  encoded properly before sent to the JSON API which caused requests
  to fail with a decoding error on the JSON API.

kvutils - The deduplication duration passed in the command is now used for command deduplication, and is no longer always overwritten with the max deduplication duration. The command deduplication duration can still be extended by the committer to account for time skews.
```

CHANGELOG_BEGIN
CHANGELOG_END
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tudor-da tudor-da tudor-da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mziolekda @tudor-da