Evidence for contract-key testing #11479

nickchapman-da · 2021-11-01T10:54:15Z

Split contract-key tests from engine tests, and mark for evidence.

Addresses item 5 of Extend test evidence #11401

CHANGELOG_BEGIN CHANGELOG_END

cocreature

Nice, thanks!

cocreature · 2021-11-01T13:27:21Z

daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/ContractKeySpec.scala

+    val submissionSeed = crypto.Hash.hashPrivateKey("contract key")
+    val txSeed = crypto.Hash.deriveTransactionSeed(submissionSeed, participant, now)
+
+    // TEST_EVIDENCE: Semantics: contract keys should be evaluated only when executing create


Suggested change

// TEST_EVIDENCE: Semantics: contract keys should be evaluated only when executing create

// TEST_EVIDENCE: Semantics: contract keys should be evaluated after ensure clause

maybe a bit clearer and matches what this test actually tests afaict.

cocreature · 2021-11-01T13:28:36Z

daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/ContractKeySpec.scala

+    // TEST_EVIDENCE: Semantics: contract keys should be evaluated after ensure clause
+    "be evaluated after ensure clause" in {
+      val templateId =
+        Identifier(basicTestsPkgId, "BasicTests:ComputeContractKeyAfterEnsureClause")


I’m confused. What is this test testing that the one above doesn’t test?
ComputeContractKeyWhenExecutingCreate just calls ComputeContractKeyAfterEnsureClause.

It looks like the first test shows the behaviour when the create is not actually executed:

let _ignore = create ComputeContractKeyAfterEnsureClause with owner

I'm not sure how useful it is to test that here, as that's just standard behaviour for a action which is not executed,

cocreature · 2021-11-01T13:32:58Z

daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/ContractKeySpec.scala

+    // Note that we provide no stability for multi key semantics so
+    // these tests serve only as an indication of the current behavior
+    // but can be changed freely.
+    "multi keys" should {


I think these deserve some markers. Not for the multi-keys behavior (although no harm in already including that) but for the uck mode (we run them in both).

added markers for uck/non-uck

cocreature · 2021-11-01T13:33:56Z

daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/EngineTest.scala

@@ -1819,6 +1819,7 @@ class EngineTest
    }
  }

+  // TEST_EVIDENCE: Semantics: Contract key behaviour
  "contract key" should {


did you intend to drop these here? It looks like they are duplicated now.

I totally did mean to drop these! Thanks for catching this. Dropped now.

@Robin-da

This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @Robin-da is in charge of this release. Commit log: ``` 7391a3c Migrate language-support codegen tests to sandbox (#11508) da76e28 iface: check for interface implementations precond (#11494) 9e045c1 Remove a leftover from `check-protobuf-stability.sh` (#11513) 17c2fa9 ErrorCodeDocumentationGenerator uses multiple prefixes for scanning classpaths (#11504) a8ae4d6 LF: Rename GenNode to Node (#11469) 73b6f8b Fixed ledger-api-bench-tool random distribution in submission phase. (#11507) 92495b0 Upgrade nixpkgs (#11490) 48afb7b interface: Add inherited choice names in scala AST (#11503) 9f8b039 [Trigger-Service] Migrate tests to sandbox (#11501) 6bafeb0 DPP-662 Support archivals in bench tool (#11474) 63d855f Pass `damlc build` logs through daml logger (#11485) 565dfac Bump rules_nodejs to 4.4.2 (#11495) 9214956 Enable experimental nix command (#11498) f81d880 LF: drop com.daml.lf.transaction.Transaction.Transaction type alias. (#11470) 505a7f5 Extend debug logging around dependencies/data-dependencies (#11488) 55d35e5 Drop TLA+ from dev-env (#11492) 3a5cb18 [Self-service error codes] Adapt all grpc assertions to additionally take self-service error codes [DPP-680] (#11437) 98e7461 LF: ContractInstance should be a CidContainer (#11487) 9afb3b3 Add and wire ledger-end-cache [DPP-703] (#11480) cdd2acc Explicitly import Java runtime from Nix/dadew (#11411) b5540a9 Evidence for contract-key testing (#11479) 78735a8 Less logging on //docs:generate-error-codes-json (#11486) d8898b8 Check fixed choices in name collision checker (#11481) 7a0198b daml-react: allow for React 17 (#11463) c415d9d Migrate trigger tests from sandbox-classic to sandbox (#11478) f9ec12b Add cocreature as a codeowner of the docs (#11450) a79cc08 DbDispatcher handles SQL exceptions with self-service error codes [DPP-690] (#11435) 164cdbb update compat versions for 1.18.0-snapshot.20211026.8179.0.e474b2d1 (#11426) 741a6e7 interfaces: Add list of fixed choices in TemplateImplements structure. (#11364) 79505b5 oracle debug (#11386) 257d536 Switch from sandbox to sandbox-classic in daml test-script (#11476) e91ced5 KV: generate self-service error docs [KVL-1148] (#11431) 8ffd835 Migrate daml script tests to Sandbox next (#11472) df65d02 Exclude dedup tests affected by current changes (#11471) 45beaf7 interfaces: typecheck for precond, haskell side. (#11468) e445fe1 LfEngineToApi conversions do not have to deal with version. (#11414) d371274 Sandbox-classic: contracts sent to the engine do not need enrichment (#11416) 05312f1 Lift out constraint tuples to synonyms in dfun contexts (#11467) a492a6c [DPP-636] Update docs on MacOS firewall issue when running tests (#11460) 5a85881 rotate release duty after 1.18.0-snapshot.20211026.8179.0.e474b2d1 (#11422) 1096f91 Adds default keepalive support for postgreSQL [DPP-697] (#11453) 3799963 Fix akka-streams shutdown at LedgerConfigurationSubscriptionFromIndex (#11462) e89da7c Move non-repudiation proxy conformance tests to their own package (#11464) b98a3ad interfaces: precondition, scala ast, decoder/encoder (#11452) fd973e6 Drop assistant integration tests for relative/absolute DAML_PROJECT (#11461) 05505e3 Multiplex multiple virtual query streams through a single web socket (#10221) 3098b70 pretty print contract IDs properly (#11359) bb4f4c5 DPP-665 Make in-flight commands configurable (#11456) bf00956 replace OneAnd party Sets with NonEmpty Set (#11420) 570160b Add LoggingValue instance for Time.Timestamp (#11444) bad50a5 Type reexports explicitly use 'type' namespace (#11451) d3b9c84 ifaces: preconditions, proto changes (#11448) 73718a2 Mark script export tests as flaky (#11449) 22e9e6b Multi-observer command submission in the ledger-api-bench-tool [DPP-660] (#11413) 3eacbf9 Bazel cache retry on connection reset by peer (#11445) fcc7e58 Make stable packages dependent on supported LF versions (#11382) 6c45f09 Remove TODO (#11446) d8b92b7 Drop flaky marker from lsp-tests (#11442) 68f4432 Improve evidence of testing (#11428) 6126fc2 Remove append only prefix from conformance tests [KVL-1152] (#11424) 926655d Drop daml ledger timeout tests from compat tests (#11441) 15cb840 Switch back to binary execution logs (#11440) ac28e61 Update ScalaPB to the latest version (0.11.6) (#11409) a71a8f9 Prevent overflow in DeduplicationPeriod (#11432) 6c88e55 Pass submission id as correlation id to error codes in Ledger API (#11381) ba10687 Replace 1.14 min version conformance test by custom test (#11433) a600f75 Bump bazel memory limit to 3gb (#11436) ebe7420 fix es ingest: file too large (#11415) d86eca0 Add documentation annotations to KV self-service errors [KVL-1144] (#11385) 46d31d5 [DPP-676][Self-service error codes] Adapt ApiConfigManagementService (#11402) 927b237 Make Oracle tests exclusive (#11408) 68d7f83 Switch bazel exec logs to json format (#11430) 12e782b ifaces: update ghc-parser (#11383) 503e391 [Short] Typo (#11410) 3031190 [DPP-676][Self-service error codes] Adapt request validators (#11379) b412f71 Fix MonotonicRecordTimeIT for pruned participants (#11423) 500e5b0 release 1.18.0-snapshot.20211026.8179.0.e474b2d1 (#11421) d678a40 LF: remove type parameter from ContractInstance (#11419) ``` Changelog: ``` - [@daml/react] Our React bindings now request the `react` library as a peer dependency, and will accept React 17 in addition to the current React 16. For new projects, the `create-daml-app` template now uses React 17. - [Integration Kit] Document KV-specific self-service errors [TS bindings] When using daml-react and daml-ledger, all streaming request to the query endpoint will be multiplexed through a single web socket. [daml LF] - Add LoggingValue instance for Time.Timestamp - [Integration Kit] - ledger-api-bench-tool can generate synthetic contracts with multiple observers [api-test-tool] - remove AppendOnly prefix from test suites as the append-only schema is the only one left ``` CHANGELOG_BEGIN CHANGELOG_END

@Robin-da

This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @Robin-da is in charge of this release. Commit log: ``` 7391a3c Migrate language-support codegen tests to sandbox (#11508) da76e28 iface: check for interface implementations precond (#11494) 9e045c1 Remove a leftover from `check-protobuf-stability.sh` (#11513) 17c2fa9 ErrorCodeDocumentationGenerator uses multiple prefixes for scanning classpaths (#11504) a8ae4d6 LF: Rename GenNode to Node (#11469) 73b6f8b Fixed ledger-api-bench-tool random distribution in submission phase. (#11507) 92495b0 Upgrade nixpkgs (#11490) 48afb7b interface: Add inherited choice names in scala AST (#11503) 9f8b039 [Trigger-Service] Migrate tests to sandbox (#11501) 6bafeb0 DPP-662 Support archivals in bench tool (#11474) 63d855f Pass `damlc build` logs through daml logger (#11485) 565dfac Bump rules_nodejs to 4.4.2 (#11495) 9214956 Enable experimental nix command (#11498) f81d880 LF: drop com.daml.lf.transaction.Transaction.Transaction type alias. (#11470) 505a7f5 Extend debug logging around dependencies/data-dependencies (#11488) 55d35e5 Drop TLA+ from dev-env (#11492) 3a5cb18 [Self-service error codes] Adapt all grpc assertions to additionally take self-service error codes [DPP-680] (#11437) 98e7461 LF: ContractInstance should be a CidContainer (#11487) 9afb3b3 Add and wire ledger-end-cache [DPP-703] (#11480) cdd2acc Explicitly import Java runtime from Nix/dadew (#11411) b5540a9 Evidence for contract-key testing (#11479) 78735a8 Less logging on //docs:generate-error-codes-json (#11486) d8898b8 Check fixed choices in name collision checker (#11481) 7a0198b daml-react: allow for React 17 (#11463) c415d9d Migrate trigger tests from sandbox-classic to sandbox (#11478) f9ec12b Add cocreature as a codeowner of the docs (#11450) a79cc08 DbDispatcher handles SQL exceptions with self-service error codes [DPP-690] (#11435) 164cdbb update compat versions for 1.18.0-snapshot.20211026.8179.0.e474b2d1 (#11426) 741a6e7 interfaces: Add list of fixed choices in TemplateImplements structure. (#11364) 79505b5 oracle debug (#11386) 257d536 Switch from sandbox to sandbox-classic in daml test-script (#11476) e91ced5 KV: generate self-service error docs [KVL-1148] (#11431) 8ffd835 Migrate daml script tests to Sandbox next (#11472) df65d02 Exclude dedup tests affected by current changes (#11471) 45beaf7 interfaces: typecheck for precond, haskell side. (#11468) e445fe1 LfEngineToApi conversions do not have to deal with version. (#11414) d371274 Sandbox-classic: contracts sent to the engine do not need enrichment (#11416) 05312f1 Lift out constraint tuples to synonyms in dfun contexts (#11467) a492a6c [DPP-636] Update docs on MacOS firewall issue when running tests (#11460) 5a85881 rotate release duty after 1.18.0-snapshot.20211026.8179.0.e474b2d1 (#11422) 1096f91 Adds default keepalive support for postgreSQL [DPP-697] (#11453) 3799963 Fix akka-streams shutdown at LedgerConfigurationSubscriptionFromIndex (#11462) e89da7c Move non-repudiation proxy conformance tests to their own package (#11464) b98a3ad interfaces: precondition, scala ast, decoder/encoder (#11452) fd973e6 Drop assistant integration tests for relative/absolute DAML_PROJECT (#11461) 05505e3 Multiplex multiple virtual query streams through a single web socket (#10221) 3098b70 pretty print contract IDs properly (#11359) bb4f4c5 DPP-665 Make in-flight commands configurable (#11456) bf00956 replace OneAnd party Sets with NonEmpty Set (#11420) 570160b Add LoggingValue instance for Time.Timestamp (#11444) bad50a5 Type reexports explicitly use 'type' namespace (#11451) d3b9c84 ifaces: preconditions, proto changes (#11448) 73718a2 Mark script export tests as flaky (#11449) 22e9e6b Multi-observer command submission in the ledger-api-bench-tool [DPP-660] (#11413) 3eacbf9 Bazel cache retry on connection reset by peer (#11445) fcc7e58 Make stable packages dependent on supported LF versions (#11382) 6c45f09 Remove TODO (#11446) d8b92b7 Drop flaky marker from lsp-tests (#11442) 68f4432 Improve evidence of testing (#11428) 6126fc2 Remove append only prefix from conformance tests [KVL-1152] (#11424) 926655d Drop daml ledger timeout tests from compat tests (#11441) 15cb840 Switch back to binary execution logs (#11440) ac28e61 Update ScalaPB to the latest version (0.11.6) (#11409) a71a8f9 Prevent overflow in DeduplicationPeriod (#11432) 6c88e55 Pass submission id as correlation id to error codes in Ledger API (#11381) ba10687 Replace 1.14 min version conformance test by custom test (#11433) a600f75 Bump bazel memory limit to 3gb (#11436) ebe7420 fix es ingest: file too large (#11415) d86eca0 Add documentation annotations to KV self-service errors [KVL-1144] (#11385) 46d31d5 [DPP-676][Self-service error codes] Adapt ApiConfigManagementService (#11402) 927b237 Make Oracle tests exclusive (#11408) 68d7f83 Switch bazel exec logs to json format (#11430) 12e782b ifaces: update ghc-parser (#11383) 503e391 [Short] Typo (#11410) 3031190 [DPP-676][Self-service error codes] Adapt request validators (#11379) b412f71 Fix MonotonicRecordTimeIT for pruned participants (#11423) 500e5b0 release 1.18.0-snapshot.20211026.8179.0.e474b2d1 (#11421) d678a40 LF: remove type parameter from ContractInstance (#11419) ``` Changelog: ``` - [@daml/react] Our React bindings now request the `react` library as a peer dependency, and will accept React 17 in addition to the current React 16. For new projects, the `create-daml-app` template now uses React 17. - [Integration Kit] Document KV-specific self-service errors [TS bindings] When using daml-react and daml-ledger, all streaming request to the query endpoint will be multiplexed through a single web socket. [daml LF] - Add LoggingValue instance for Time.Timestamp - [Integration Kit] - ledger-api-bench-tool can generate synthetic contracts with multiple observers [api-test-tool] - remove AppendOnly prefix from test suites as the append-only schema is the only one left ``` CHANGELOG_BEGIN CHANGELOG_END Co-authored-by: Azure Pipelines Daml Build <[email protected]>

Split contract-key tests from engine tests, and mark for evidence.

850b568

CHANGELOG_BEGIN CHANGELOG_END

nickchapman-da requested review from cocreature and remyhaemmerle-da as code owners November 1, 2021 10:54

cocreature approved these changes Nov 1, 2021

View reviewed changes

nickchapman-da added 2 commits November 1, 2021 16:01

remove contract key tests from their original location

66f35e5

evidence for unique/non-unique contract keys

fbd85d2

nickchapman-da added the automerge label Nov 1, 2021

mergify bot merged commit b5540a9 into main Nov 1, 2021

mergify bot deleted the nick-evidence-contract-key-tests branch November 1, 2021 16:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Evidence for contract-key testing #11479

Evidence for contract-key testing #11479

nickchapman-da commented Nov 1, 2021

cocreature left a comment

cocreature Nov 1, 2021

cocreature Nov 1, 2021

nickchapman-da Nov 1, 2021

cocreature Nov 1, 2021

nickchapman-da Nov 1, 2021

cocreature Nov 1, 2021

nickchapman-da Nov 1, 2021

	// TEST_EVIDENCE: Semantics: contract keys should be evaluated only when executing create
	// TEST_EVIDENCE: Semantics: contract keys should be evaluated after ensure clause

Evidence for contract-key testing #11479

Evidence for contract-key testing #11479

Conversation

nickchapman-da commented Nov 1, 2021

cocreature left a comment

Choose a reason for hiding this comment

cocreature Nov 1, 2021

Choose a reason for hiding this comment

cocreature Nov 1, 2021

Choose a reason for hiding this comment

nickchapman-da Nov 1, 2021

Choose a reason for hiding this comment

cocreature Nov 1, 2021

Choose a reason for hiding this comment

nickchapman-da Nov 1, 2021

Choose a reason for hiding this comment

cocreature Nov 1, 2021

Choose a reason for hiding this comment

nickchapman-da Nov 1, 2021

Choose a reason for hiding this comment