Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: Call _wrap_rule directly when building the Scala REPL rule. #11279

Merged
1 commit merged into from
Oct 18, 2021
Merged

Bazel: Call _wrap_rule directly when building the Scala REPL rule. #11279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions bazel_tools/scala.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,12 +554,7 @@ def _create_scaladoc_jar(

def _create_scala_repl(
name,
deps = [],
scala_deps = [],
versioned_deps = {},
versioned_scala_deps = {},
runtime_deps = [],
scala_runtime_deps = [],
tags = [],
# hiding the following from the `scala_repl` rule
main_class = None,
Expand All @@ -569,10 +564,9 @@ def _create_scala_repl(
generated_srcs = None,
**kwargs):
name = name + "_repl"
deps = resolve_scala_deps(deps, scala_deps, versioned_deps, versioned_scala_deps)
runtime_deps = resolve_scala_deps(runtime_deps, scala_runtime_deps) + ["@maven//:org_jline_jline"]
runtime_deps = runtime_deps + ["@maven//:org_jline_jline"]
tags = tags + ["manual"]
_wrap_rule(scala_repl, name = name, deps = deps, runtime_deps = runtime_deps, tags = tags, **kwargs)
_wrap_rule(scala_repl, name = name, runtime_deps = runtime_deps, tags = tags, **kwargs)

def da_scala_library(name, **kwargs):
"""
Expand Down