Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPP-650 Remove the mutating schema #11211

Merged
merged 9 commits into from
Oct 21, 2021
Merged

DPP-650 Remove the mutating schema #11211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9ad4b0c
Remove the mutating schema
rautenrieth-da Oct 12, 2021
9222af6
Fix post-commit validation test
rautenrieth-da Oct 12, 2021
6b2ea02
Remove append-only flags from CI
rautenrieth-da Oct 12, 2021
4ce9707
Don't crash when using deprecated flag
rautenrieth-da Oct 12, 2021
519f83e
Increase timeout for reset service tests
rautenrieth-da Oct 12, 2021
b4ef209
Fix typos in parameter names
rautenrieth-da Oct 18, 2021
2edaa36
Restore removed test
rautenrieth-da Oct 18, 2021
55172fe
Restore removed CLI check
rautenrieth-da Oct 18, 2021
278d144
Improve CLI parameter description
rautenrieth-da Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion daml-script/export/integration-tests/export-lf-1.6/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ client_server_build(
"--ledgerid=lf16-export-ledger",
"--port=0",
"--port-file=%PORT_FILE%",
"--enable-append-only-schema",
],
server_files = ["lf16.build"],
)
Expand Down
1 change: 0 additions & 1 deletion daml-script/export/integration-tests/matches-docs/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ client_server_build(
server_args = [
"--port=0",
"--port-file=%PORT_FILE%",
"--enable-append-only-schema",
],
server_files = ["//daml-script/test:script-test.dar"],
)
Expand Down
1 change: 0 additions & 1 deletion ledger/daml-on-sql/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ conformance_test(
"--ledgerid=conformance-test",
"--port=6865",
"--eager-package-loading",
"--enable-append-only-schema",
],
test_tool_args = [
"--verbose",
Expand Down
1 change: 0 additions & 1 deletion ledger/indexer-benchmark/src/main/scala/ledger/indexerbenchmark/Config.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ object Config {
participantId = Ref.ParticipantId.assertFromString("IndexerBenchmarkParticipant"),
jdbcUrl = "",
startupMode = IndexerStartupMode.MigrateAndStart,
enableAppendOnlySchema = true,
),
waitForUserInput = false,
minUpdateRate = None,
Expand Down
6 changes: 1 addition & 5 deletions ledger/indexer-benchmark/src/main/scala/ledger/indexerbenchmark/IndexerBenchmark.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import com.daml.lf.data.Time
import com.daml.logging.LoggingContext
import com.daml.logging.LoggingContext.newLoggingContext
import com.daml.metrics.{JvmMetricSet, Metrics}
import com.daml.platform.configuration.ServerRole
import com.daml.platform.indexer.{JdbcIndexer, StandaloneIndexerServer}
import com.daml.platform.store.LfValueTranslationCache
import com.daml.testing.postgresql.PostgresResource
Expand Down Expand Up @@ -70,7 +69,6 @@ class IndexerBenchmark() {
println("Creating read service and indexer...")
val readService = createReadService(updates)
val indexerFactory = new JdbcIndexer.Factory(
ServerRole.Indexer,
config.indexerConfig,
readService,
indexerEC,
Expand All @@ -91,8 +89,7 @@ class IndexerBenchmark() {
.result(
StandaloneIndexerServer
.migrateOnly(
jdbcUrl = config.indexerConfig.jdbcUrl,
enableAppendOnlySchema = config.indexerConfig.enableAppendOnlySchema,
jdbcUrl = config.indexerConfig.jdbcUrl
)
.map(_ => indexerFactory.initialized())(indexerEC),
Duration(5, "minute"),
Expand Down Expand Up @@ -135,7 +132,6 @@ class IndexerBenchmark() {
| jdbcUrl: ${config.indexerConfig.jdbcUrl}
|
|Indexer parameters:
| enableAppendOnlySchema: ${config.indexerConfig.enableAppendOnlySchema}
| maxInputBufferSize: ${config.indexerConfig.maxInputBufferSize}
| inputMappingParallelism: ${config.indexerConfig.inputMappingParallelism}
| ingestionParallelism: ${config.indexerConfig.ingestionParallelism}
Expand Down
5 changes: 0 additions & 5 deletions ledger/ledger-on-memory/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ conformance_test(
"--contract-id-seeding=testing-weak",
"--participant=participant-id=example,port=6865",
"--max-deduplication-duration=PT5S",
"--index-append-only-schema",
"--mutable-contract-state-cache",
],
test_tool_args = [
Expand Down Expand Up @@ -175,7 +174,6 @@ conformance_test(
"--participant=participant-id=example,port=6865",
"--daml-lf-min-version-1.14-unsafe",
"--max-deduplication-duration=PT5S",
"--index-append-only-schema",
"--mutable-contract-state-cache",
],
test_tool_args = [
Expand All @@ -195,7 +193,6 @@ conformance_test(
server = ":app",
server_args = [
"--contract-id-seeding=testing-weak",
"--index-append-only-schema",
"--mutable-contract-state-cache",
"--participant=participant-id=example1,port=6865",
"--participant=participant-id=example2,port=6866",
Expand Down Expand Up @@ -223,7 +220,6 @@ conformance_test(
server = ":app",
server_args = [
"--contract-id-seeding=testing-weak",
"--index-append-only-schema",
"--mutable-contract-state-cache",
"--participant=participant-id=split-example,port=6865,server-jdbc-url=jdbc:h2:mem:split-example;db_close_delay=-1;db_close_on_exit=false,shard-name=server1,run-mode=ledger-api-server",
"--participant=participant-id=split-example,port=6865,server-jdbc-url=jdbc:h2:mem:split-example;db_close_delay=-1;db_close_on_exit=false,shard-name=indexer,run-mode=indexer",
Expand All @@ -250,7 +246,6 @@ conformance_test(
server_args = [
"--contract-id-seeding=testing-weak",
"--participant=participant-id=example,port=6865",
"--index-append-only-schema",
"--mutable-contract-state-cache",
],
test_tool_args = [
Expand Down
10 changes: 1 addition & 9 deletions ledger/ledger-on-sql/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ da_scala_test_suite(
"--contract-id-seeding=testing-weak",
"--participant participant-id=conformance-test,port=6865",
"--max-deduplication-duration=PT5S",
"--index-append-only-schema",
"--mutable-contract-state-cache",
] + db.get("conformance_test_server_args", []),
tags = db.get("conformance_test_tags", []),
Expand All @@ -279,7 +278,6 @@ da_scala_test_suite(
server_args = [
"--contract-id-seeding=testing-weak",
"--participant participant-id=example,port=6865",
"--index-append-only-schema",
"--mutable-contract-state-cache",
] + db.get("conformance_test_server_args", []),
tags = db.get("benchmark_performance_envelope_tags", []),
Expand Down Expand Up @@ -315,7 +313,6 @@ conformance_test(
server_args = [
"--contract-id-seeding=testing-weak",
"--participant participant-id=conformance-test,port=6865,contract-state-cache-max-size=1,contract-key-state-cache-max-size=1",
"--index-append-only-schema",
"--mutable-contract-state-cache",
"--max-deduplication-duration=PT5S",
],
Expand All @@ -342,7 +339,6 @@ conformance_test(
server_args = [
"--contract-id-seeding=testing-weak",
"--participant participant-id=conformance-test,port=6865,contract-state-cache-max-size=1,contract-key-state-cache-max-size=1",
"--index-append-only-schema",
"--mutable-contract-state-cache",
"--jdbc-url=jdbc:h2:mem:daml-on-sql-conformance-test",
"--max-deduplication-duration=PT5S",
Expand Down Expand Up @@ -370,7 +366,6 @@ conformance_test(
server_args = [
"--contract-id-seeding=testing-weak",
"--participant participant-id=conformance-test,port=6865,contract-state-cache-max-size=1,contract-key-state-cache-max-size=1",
"--index-append-only-schema",
"--mutable-contract-state-cache",
"--max-deduplication-duration=PT5S",
],
Expand All @@ -397,7 +392,6 @@ conformance_test(
server_args = [
"--contract-id-seeding=testing-weak",
"--participant participant-id=conformance-test,port=6865,contract-state-cache-max-size=1,contract-key-state-cache-max-size=1,ledger-api-transactions-buffer-max-size=10",
"--index-append-only-schema",
"--mutable-contract-state-cache",
"--buffered-ledger-api-streams-unsafe",
"--max-deduplication-duration=PT5S",
Expand All @@ -419,13 +413,12 @@ conformance_test(

# Feature test: --buffered-ledger-api-streams-unsafe (in-memory fan-out) (Oracle)
conformance_test(
name = "conformance-test-append-only-in-memory-fan-out-oracle",
name = "conformance-test-in-memory-fan-out-oracle",
ports = [6865],
server = ":conformance-test-oracle-bin",
server_args = [
"--contract-id-seeding=testing-weak",
"--participant participant-id=conformance-test,port=6865,contract-state-cache-max-size=1,contract-key-state-cache-max-size=1,ledger-api-transactions-buffer-max-size=10",
"--index-append-only-schema",
"--mutable-contract-state-cache",
"--buffered-ledger-api-streams-unsafe",
"--max-deduplication-duration=PT5S",
Expand Down Expand Up @@ -455,7 +448,6 @@ conformance_test(
server_args = [
"--contract-id-seeding=testing-weak",
"--participant participant-id=conformance-test,port=6865,contract-state-cache-max-size=1,contract-key-state-cache-max-size=1",
"--index-append-only-schema",
"--mutable-contract-state-cache",
"--jdbc-url=jdbc:h2:mem:daml-on-sql-conformance-test",
],
Expand Down
1 change: 0 additions & 1 deletion ...ation-api/src/main/resources/db/migration/h2database/V10__Loosen_transaction_check.sha256
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions ...egration-api/src/main/resources/db/migration/h2database/V10__Loosen_transaction_check.sql
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...i/src/main/resources/db/migration/h2database/V11__Create_command_completions_table.sha256
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions ...-api/src/main/resources/db/migration/h2database/V11__Create_command_completions_table.sql
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...egration-api/src/main/resources/db/migration/h2database/V12__Command_deduplication.sha256
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions ...integration-api/src/main/resources/db/migration/h2database/V12__Command_deduplication.sql
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...-integration-api/src/main/resources/db/migration/h2database/V13__Events_new_schema.sha256
View file
Open in desktop

This file was deleted.

74 changes: 0 additions & 74 deletions ...ant-integration-api/src/main/resources/db/migration/h2database/V13__Events_new_schema.sql
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...ant-integration-api/src/main/resources/db/migration/h2database/V14__Stable_offsets.sha256
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions ...cipant-integration-api/src/main/resources/db/migration/h2database/V14__Stable_offsets.sql
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...ion-api/src/main/resources/db/migration/h2database/V15__Remove_maximum_record_time.sha256
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions ...ration-api/src/main/resources/db/migration/h2database/V15__Remove_maximum_record_time.sql
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...integration-api/src/main/resources/db/migration/h2database/V16__Delete_checkpoints.sha256
View file
Open in desktop

This file was deleted.

Loading