-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a notice to the release testing rotation file #11142
Conversation
Reminds people adding new users to the rotation that they should also be added to DACH-NY/daml-language-ad-hoc to have a box in the cloud for Windows testing. Adds the possibility of adding comments at the beginning of the rotation file. changelog_begin changelog_end
TestingI manually tested that I manually tested @@ -1,7 +1,6 @@
# If you are adding someone to the rotation, remember to also give them permission
# to access an ad-hoc machine for Windows testing. This can be done by opening a PR
# like the following: https://github.com/DACH-NY/daml-language-ad-hoc/pull/37
-U02DCD54R28 adriaanm-da
U7BSDJUJX S11001001
U011H6KFYPN sofiafaro-da
U026PEZLTPX akshayshirahatti-da
@@ -15,3 +14,4 @@ U02DAFHFXUN akrmn
UEHLS0JUB cocreature
UEHSF89AQ garyverhaegen-da
UD3MUK6TA stefanobaghino-da
+U02DCD54R28 adriaanm-da |
@@ -28,6 +28,6 @@ jobs: | |||
|
|||
source "$(bash_lib)" | |||
|
|||
RELEASE_MANAGER=$(head -1 release/rotation | awk '{print $1}') | |||
RELEASE_MANAGER=$(awk '/^[^#]/ {print $1}' release/rotation | head -n 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing those two diffs side-by-side now, do you think it'd be worth to move that to a function in bash-lib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented on the second one but there are actually 5 instances, so I think we're definitely past the threshold where a function makes sense. I can do it as a separate PR if you want, though. No need to block this one on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please. I'll merge this. 🙇🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reminds people adding new users to the rotation that they should also be added to DACH-NY/daml-language-ad-hoc to have a box in the cloud for Windows testing. Adds the possibility of adding comments at the beginning of the rotation file. changelog_begin changelog_end
Reminds people adding new users to the rotation that they should also
be added to DACH-NY/daml-language-ad-hoc to have a box in the cloud
for Windows testing.
Adds the possibility of adding comments at the beginning of the rotation file.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGIN
andCHANGELOG_END
tagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.