participant-integration-api: Switch to the v2 participant state API. [KVL-1002] #10398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2021
miklos-da
reviewed
Jul 26, 2021
ledger/sandbox-classic/src/main/scala/platform/sandbox/stores/ledger/ScenarioLoader.scala
Outdated
Show resolved
Hide resolved
ledger/participant-state/src/main/scala/com/daml/ledger/participant/state/v2/Update.scala
Show resolved
Hide resolved
...ticipant-state/src/main/scala/com/daml/ledger/participant/state/v2/DeduplicationPeriod.scala
Show resolved
Hide resolved
ledger/participant-state/src/main/scala/com/daml/ledger/participant/state/v2/ChangeId.scala
Show resolved
Hide resolved
...er/participant-state/src/main/scala/com/daml/ledger/participant/state/v1/SubmitterInfo.scala
Outdated
Show resolved
Hide resolved
ledger/participant-integration-api/src/test/suite/scala/platform/store/ConversionsSpec.scala
Show resolved
Hide resolved
...gration-api/src/main/scala/platform/apiserver/execution/LedgerTimeAwareCommandExecutor.scala
Show resolved
Hide resolved
ghost
commented
Jul 26, 2021
...src/test/suite/scala/com/digitalasset/ledger/api/validation/SubmitRequestValidatorTest.scala
Outdated
Show resolved
Hide resolved
`CompletionInfo` is identical to `SubmitterInfo`. Its purpose is to make the migration to v2 easier. It should not make it into the final version.
This means that:
- the API server and indexer expect v2 API traits
- adapters are provided if you need to elevate your v1 API usage
- the indexer internally uses v2 Updates
- rejections are switched over to use the v2 format
- Sandbox Classic uses v2 as the internal representation too (because
it interacts directly with the underlying indexer representation,
and is therefore tightly coupled)
_kvutils_ and other users of the `StandaloneApiServer` and
`StandaloneIndexerServer` use the adapters.
CHANGELOG_BEGIN
- [Integration Kit] The API server and indexer have switched over to v2
of the participant-state API. You can continue to use the v1 API, but
you will need to wrap your ``ReadService`` and ``WriteService``
objects in the ``AdaptedV1ReadService`` and ``AdaptedV1WriteSerivce``
classes.
CHANGELOG_END
It's served its purpose.
ghost
force-pushed
the
samir/participant-integration-api/v2-state
branch
from
6773acf to
2efbc76
Compare
ghost
changed the title
ghost
marked this pull request as ready for review
ghost
requested review from
fabiotudone-da,
gerolf-da,
mziolekda,
nicu-da,
nmarton-da,
rautenrieth-da,
stefanobaghino-da and
tudor-da
as code owners
…egration-api/v2-state
fabiotudone-da
approved these changes
Jul 27, 2021
...ger-api-common/src/main/scala/com/digitalasset/ledger/api/validation/CommandsValidator.scala
Outdated
Show resolved
Hide resolved
...i-common/src/main/scala/com/digitalasset/platform/server/api/validation/ErrorFactories.scala
Show resolved
Hide resolved
ledger/participant-integration-api/src/main/scala/platform/store/dao/JdbcLedgerDao.scala
Outdated
Show resolved
Hide resolved
Just a little bit of cleanup.
…egration-api/v2-state
miklos-da
approved these changes
Jul 27, 2021
...cipant-integration-api/src/main/scala/platform/apiserver/services/ApiSubmissionService.scala
Outdated
Show resolved
Hide resolved
And introduce a trait, because, well, this is still the JVM.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mziolekda
reviewed
Jul 27, 2021
...cipant-integration-api/src/main/scala/platform/apiserver/services/ApiSubmissionService.scala
Show resolved
Hide resolved
ghost
commented
Jul 28, 2021
Comment on lines
-167
to
-168
| case state.SubmissionResult.NotSupported => | ||
| logger.info("Setting an initial ledger configuration is not supported") |
There was a problem hiding this comment.
@mziolekda pointed out that removing this might cause issues with ledgers + drivers such as Canton that don't support submitting configuration. As these drivers have other ways of managing configuration, I'm going to change LedgerConfiguration to allow them to state that we should never submit a new configuration, instead just waiting indefinitely for one to show up. @oliverse-da has agreed this approach will work for Canton.
I'll make this change separately.
…egration-api/v2-state
mziolekda
approved these changes
Jul 28, 2021
|
Agreed, it's huge. If it helps, imagine how big it would have been if we did it in one PR instead of 17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In which we draw the rest of the owl.
Switching to the v2 participant state API means:
kvutils and other users of the
StandaloneApiServerandStandaloneIndexerServeruse the adapters.Changelog
ReadServiceandWriteServiceobjects in theAdaptedV1ReadServiceandAdaptedV1WriteSerivceclasses.Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.