Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables flaky test suite of InstrumentedSource.bufferedSource #10321

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Disables flaky test suite of InstrumentedSource.bufferedSource #10321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ledger/metrics/src/test/suite/scala/com/daml/metrics/InstrumentedSourceSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ final class InstrumentedSourceSpec extends AsyncFlatSpec with Matchers with Akka
}
}

// this test suite is disabled since it's timing related expectations proven to be very flaky in automated tests
behavior of "InstrumentedSource.bufferedSource"

def throttledTest(producerMaxSpeed: Int, consumerMaxSpeed: Int): Future[List[Long]] = {
Expand All @@ -166,7 +167,7 @@ final class InstrumentedSourceSpec extends AsyncFlatSpec with Matchers with Akka
def samplePercentage(samples: List[Long])(filter: Long => Boolean): Double =
samples.count(filter).toDouble / samples.size.toDouble * 100.0

it should "signal mostly full buffer if slow consumer" in {
it should "signal mostly full buffer if slow consumer" ignore {
throttledTest(
producerMaxSpeed = 10,
consumerMaxSpeed = 5,
Expand All @@ -176,7 +177,7 @@ final class InstrumentedSourceSpec extends AsyncFlatSpec with Matchers with Akka
}
}

it should "signal mostly empty buffer if fast consumer" in {
it should "signal mostly empty buffer if fast consumer" ignore {
throttledTest(
producerMaxSpeed = 10,
consumerMaxSpeed = 20,
Expand All @@ -186,7 +187,7 @@ final class InstrumentedSourceSpec extends AsyncFlatSpec with Matchers with Akka
}
}

it should "signal mostly empty buffer if speeds are aligned" in {
it should "signal mostly empty buffer if speeds are aligned" ignore {
throttledTest(
producerMaxSpeed = 10,
consumerMaxSpeed = 10,
Expand All @@ -196,7 +197,7 @@ final class InstrumentedSourceSpec extends AsyncFlatSpec with Matchers with Akka
}
}

it should "signal mostly empty buffer if consumer slightly faster" in {
it should "signal mostly empty buffer if consumer slightly faster" ignore {
throttledTest(
producerMaxSpeed = 10,
consumerMaxSpeed = 12,
Expand All @@ -206,7 +207,7 @@ final class InstrumentedSourceSpec extends AsyncFlatSpec with Matchers with Akka
}
}

it should "signal mostly full buffer if consumer slightly slower" in {
it should "signal mostly full buffer if consumer slightly slower" ignore {
throttledTest(
producerMaxSpeed = 10,
consumerMaxSpeed = 8,
Expand Down