Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print version of the ledger api test tool as part of the report #10119

Merged
merged 2 commits into from
Jun 28, 2021
Merged

print version of the ledger api test tool as part of the report #10119

merged 2 commits into from
Jun 28, 2021

Conversation

mziolekda
Copy link
Contributor

This change enables reasoning about outcomes of CI runs in various (sometimes foreign) repositories
CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

rautenrieth-da
rautenrieth-da approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@rautenrieth-da rautenrieth-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only print the version of the ledger api test tool, and not the version of the participant(s). Is that enough for your purpose?

...dger-api-test-tool/src/main/scala/com/daml/ledger/api/testtool/infrastructure/Reporter.scala
@@ -105,7 +107,7 @@ object Reporter {
s.println()
s.println(blue("#" * 80))
s.println(blue("#"))
s.println(blue("# TEST REPORT"))
s.println(blue(s"# TEST REPORT, version: ${BuildInfo.Version}"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have added a line in the ### RUN INFORMATION section (where you could also print additional details like the participant configuration), but I have no strong opinion on this.

@mziolekda mziolekda merged commit ffc88d5 into main Jun 28, 2021
@mziolekda mziolekda deleted the mziolek/version-in-ledger-api-test-tool-report branch June 28, 2021 15:35
azure-pipelines bot pushed a commit that referenced this pull request Jun 30, 2021
release 1.15.0-snapshot.20210630.7261.0.84e1f3a7
a60631e 
This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@sofiafaro-da is in charge of this release.

Commit log:
```
84e1f3a participant-integration-api: Move transaction requests to structured logging. [KVL-996] (#10141)
b79d02e `ledger-api-bench-tool` - exposed metrics for Prometheus [DPP-471] (#10103)
b61e519 Release ledger API test tool per LF version (#10142)
2dfe026 add ES cluster (#10144)
ef9a04c Divulgence crash tests [DPP-433] (#9942)
bb46417 Daml assistant capitalization (#10140)
a6ee10b Move visibility checks into speedy. (#10136)
c764fbe contextualized-logging: Introduce different logging types for more structure. [KVL-996] (#10134)
678cab0 10050 append only schema on oracle (#10051)
f5e5062 ensure that signatories and observers are disjoint in ledger-api CreatedEvents (#10123)
ffc88d5 print version of the ledger api test tool as part of the report (#10119)
621cfa4 Resolve contract keys conflicts in disclosed contracts (#9948) (#10034)
f1ffd52 Java bindings: add DamlRecord, deprecate Record (#10132)
3df2566 Scenario: move Scenario Error Throwable to scenario package (#10075)
7521ec9 [JSON-API] Include contract id in the logging ctx when logging exercise commands (#10131)
e0e3333 update NOTICES file (#10129)
398300b LF: Move Speedy Interpretation Error to transaction package (#10091)
d4150ac Refactor error reporting in Daml Repl (#10118)
0108fed update NOTICES file (#10112)
6af36fe Fix Tx.Metadata for normalized transactions (#10108)
7745693 Remove duplicate index (#10084)
1b617ae DPP-428 Add missing indices for index initialization (#10083)
af9382c contextualized-logging: Reduce the API surface and avoid name collisions. (#10102)
01d6770 json-api perf tests: combine large-ACS frequencies combinatorially instead of in lockstep (#10101)
a44afcf Upgrade nixpkgs (#9908)
9498d15 [DOCS] Let jwt.io link to an already filled in working payload (#10026)
4affb05 Force newer version of glob-parent in Navigator (#10105)
f745f10 LF: Realease LF 1.14 (#10077)
05056dd Cut a flaky expectation some more slack (#10106)
46a66e2 Upgrade jest to the latest version (#10107)
84e3298 update compat versions for 1.11.2 (#10104)
a6b536f Compiler: Make LF 1.13 the default output (#9907)
29ddc88 remove redundant spaces in the log format (#10093)
01e329f DPP-432 Add exception tests to the JdbcLedgerDao suite (#10040)
3d79cbf Bump compat versions (#10096)
5bf7d8f Fix speedy perf reporting (#10100)
0970821 Bump cpu alloc for build-and-lint (#10099)
cbca779 [In-memory fan-out] Ensure getTransactionLogUpdates with max fetch size (#10064)
c756153 Release SDK 1.11.2 (#10094)
3a42354 rotate release duty after 1.15.0-snapshot.20210622.7213.0.d867d904 (#10086)
ecc2d11 recommend some daml compiler warnings to enable (#10082)
b2bb45e Bump daml repl timeout (#10089)
db60d15 Log ledger api validation failures at info level (#10080)
f0dc025 Release 1.15 snapshot (#10090)
```
Changelog:
```
- [Ledger API Server] The amount of data logged in the API transaction
  service has been reduced at INFO level. Please enable TRACE logging to
  log the request data structures.
- [Integration Kit] - ledger-api-bench-tool - exposed metrics via Dropwizard metrics (e.g. for Prometheus)
- The log output of Daml components has changed so that the structured
  part is closer to JSON. This allows us to distinguish and parse
  numbers and lists. If you are parsing this log output, you may need to
  change your parser.
  The log output has changed from:
  .. code-block::
     context: {a=b, x=1, foo=bar, parties=[alice, bob]}
  to:
  .. code-block::
     context: {a: "b", x: 1, foo: "bar", parties: ["alice", "bob"]}
In case a contract key is already present in a past contract in the contract table nullify it. This gets rid of contract keys of previously disclosed contracts. We never discover that disclosed contracts get archived, so we get conflicts on such past keys
[Java bindings] In order to avoid clashing with `java.lang.Record` (introduced
in Java 14), `com.daml.ledger.javaapi.data.Record` has been renamed to
`com.daml.ledger.javaapi.data.DamlRecord`. The old name has been used to
denote a sub-type of the newly renamed one, so it can still be used, but it has
been marked as deprecated.
[Java codegen] The Java codegen now uses the `DamlRecord` type wherever `Record`
was used before.
- [JSON-API] The contract id is now also included in the logging ctx when logging exercise commands
- [LF] Add support for Excepction
- [Compiler] Default ouput LF version is now 1.13
Log ledger api validation failures at info level
```

CHANGELOG_BEGIN
CHANGELOG_END
sofiafaro-da pushed a commit that referenced this pull request Jun 30, 2021
@azure-pipelines
release 1.15.0-snapshot.20210630.7261.0.84e1f3a7 (#10146)
7e068d6 
This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@sofiafaro-da is in charge of this release.

Commit log:
```
84e1f3a participant-integration-api: Move transaction requests to structured logging. [KVL-996] (#10141)
b79d02e `ledger-api-bench-tool` - exposed metrics for Prometheus [DPP-471] (#10103)
b61e519 Release ledger API test tool per LF version (#10142)
2dfe026 add ES cluster (#10144)
ef9a04c Divulgence crash tests [DPP-433] (#9942)
bb46417 Daml assistant capitalization (#10140)
a6ee10b Move visibility checks into speedy. (#10136)
c764fbe contextualized-logging: Introduce different logging types for more structure. [KVL-996] (#10134)
678cab0 10050 append only schema on oracle (#10051)
f5e5062 ensure that signatories and observers are disjoint in ledger-api CreatedEvents (#10123)
ffc88d5 print version of the ledger api test tool as part of the report (#10119)
621cfa4 Resolve contract keys conflicts in disclosed contracts (#9948) (#10034)
f1ffd52 Java bindings: add DamlRecord, deprecate Record (#10132)
3df2566 Scenario: move Scenario Error Throwable to scenario package (#10075)
7521ec9 [JSON-API] Include contract id in the logging ctx when logging exercise commands (#10131)
e0e3333 update NOTICES file (#10129)
398300b LF: Move Speedy Interpretation Error to transaction package (#10091)
d4150ac Refactor error reporting in Daml Repl (#10118)
0108fed update NOTICES file (#10112)
6af36fe Fix Tx.Metadata for normalized transactions (#10108)
7745693 Remove duplicate index (#10084)
1b617ae DPP-428 Add missing indices for index initialization (#10083)
af9382c contextualized-logging: Reduce the API surface and avoid name collisions. (#10102)
01d6770 json-api perf tests: combine large-ACS frequencies combinatorially instead of in lockstep (#10101)
a44afcf Upgrade nixpkgs (#9908)
9498d15 [DOCS] Let jwt.io link to an already filled in working payload (#10026)
4affb05 Force newer version of glob-parent in Navigator (#10105)
f745f10 LF: Realease LF 1.14 (#10077)
05056dd Cut a flaky expectation some more slack (#10106)
46a66e2 Upgrade jest to the latest version (#10107)
84e3298 update compat versions for 1.11.2 (#10104)
a6b536f Compiler: Make LF 1.13 the default output (#9907)
29ddc88 remove redundant spaces in the log format (#10093)
01e329f DPP-432 Add exception tests to the JdbcLedgerDao suite (#10040)
3d79cbf Bump compat versions (#10096)
5bf7d8f Fix speedy perf reporting (#10100)
0970821 Bump cpu alloc for build-and-lint (#10099)
cbca779 [In-memory fan-out] Ensure getTransactionLogUpdates with max fetch size (#10064)
c756153 Release SDK 1.11.2 (#10094)
3a42354 rotate release duty after 1.15.0-snapshot.20210622.7213.0.d867d904 (#10086)
ecc2d11 recommend some daml compiler warnings to enable (#10082)
b2bb45e Bump daml repl timeout (#10089)
db60d15 Log ledger api validation failures at info level (#10080)
f0dc025 Release 1.15 snapshot (#10090)
```
Changelog:
```
- [Ledger API Server] The amount of data logged in the API transaction
  service has been reduced at INFO level. Please enable TRACE logging to
  log the request data structures.
- [Integration Kit] - ledger-api-bench-tool - exposed metrics via Dropwizard metrics (e.g. for Prometheus)
- The log output of Daml components has changed so that the structured
  part is closer to JSON. This allows us to distinguish and parse
  numbers and lists. If you are parsing this log output, you may need to
  change your parser.
  The log output has changed from:
  .. code-block::
     context: {a=b, x=1, foo=bar, parties=[alice, bob]}
  to:
  .. code-block::
     context: {a: "b", x: 1, foo: "bar", parties: ["alice", "bob"]}
In case a contract key is already present in a past contract in the contract table nullify it. This gets rid of contract keys of previously disclosed contracts. We never discover that disclosed contracts get archived, so we get conflicts on such past keys
[Java bindings] In order to avoid clashing with `java.lang.Record` (introduced
in Java 14), `com.daml.ledger.javaapi.data.Record` has been renamed to
`com.daml.ledger.javaapi.data.DamlRecord`. The old name has been used to
denote a sub-type of the newly renamed one, so it can still be used, but it has
been marked as deprecated.
[Java codegen] The Java codegen now uses the `DamlRecord` type wherever `Record`
was used before.
- [JSON-API] The contract id is now also included in the logging ctx when logging exercise commands
- [LF] Add support for Excepction
- [Compiler] Default ouput LF version is now 1.13
Log ledger api validation failures at info level
```

CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines DAML Build <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rautenrieth-da rautenrieth-da rautenrieth-da approved these changes

@gerolf-da gerolf-da Awaiting requested review from gerolf-da

@nmarton-da nmarton-da Awaiting requested review from nmarton-da

@tudor-da tudor-da Awaiting requested review from tudor-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mziolekda @rautenrieth-da