kvutils: Refined transaction validation [KVL-1015]

ledger/participant-state/kvutils/src/main/scala/com/daml/ledger/participant/state/kvutils/committer/transaction/TransactionCommitter.scala

@@ -11,9 +11,9 @@ import com.daml.ledger.participant.state.kvutils.DamlKvutils._
 import com.daml.ledger.participant.state.kvutils.committer.Committer._
 import com.daml.ledger.participant.state.kvutils.committer._
 import com.daml.ledger.participant.state.kvutils.committer.transaction.validation.{
-  ContractKeysValidator,
   LedgerTimeValidator,
   ModelConformanceValidator,
+  TransactionConsistencyValidator,
 }
 import com.daml.ledger.participant.state.kvutils.{Conversions, Err}
 import com.daml.ledger.participant.state.v1.RejectionReasonV0
@@ -75,10 +75,8 @@ private[kvutils] class TransactionCommitter(
     "check_informee_parties_allocation" -> checkInformeePartiesAllocation,
     "deduplicate" -> deduplicateCommand,
     "validate_ledger_time" -> ledgerTimeValidator.createValidationStep(rejections),
-    "validate_contract_keys" -> ContractKeysValidator.createValidationStep(rejections),
-    "validate_model_conformance" -> modelConformanceValidator.createValidationStep(
-      rejections
-    ),
+    "validate_model_conformance" -> modelConformanceValidator.createValidationStep(rejections),
+    "validate_consistency" -> TransactionConsistencyValidator.createValidationStep(rejections),
     "blind" -> blind,
     "trim_unnecessary_nodes" -> trimUnnecessaryNodes,
     "build_final_log_entry" -> buildFinalLogEntry,
@@ -218,9 +216,8 @@ private[kvutils] class TransactionCommitter(
         case Nil => result
         case head :: tail =>
           import TransactionOuterClass.Node.NodeTypeCase
-          val node = nodeMap
-            .get(head)
-            .getOrElse(throw Err.InternalError(s"Invalid transaction node id $head"))
+          val node =
+            nodeMap.getOrElse(head, throw Err.InternalError(s"Invalid transaction node id $head"))
           node.getNodeTypeCase match {
             case NodeTypeCase.CREATE =>
               goNodesToKeep(tail, result + head)