Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test transaction validation. #6665

Closed
remyhaemmerle-da opened this issue Jul 9, 2020 · 1 comment
Closed

Test transaction validation. #6665

remyhaemmerle-da opened this issue Jul 9, 2020 · 1 comment
Labels
component/daml-engine DAML-LF Engine & Interpreter

Comments

@remyhaemmerle-da
Copy link
Collaborator

remyhaemmerle-da commented Jul 9, 2020 •
edited by nickchapman-da
Loading

Transaction validation should be extensively tested to avoid bug described in #6664

In particular the following point should be tests:

  • translation of transaction nodes to speedy command
  • computation of global contract IDs during transaction validation (following the scheme described in the contract ID specification
  • comparison of submitted transaction with the replay transaction.

Consider also specifying validation.

Also using this issue for refactoring work:
@remyhaemmerle-da remyhaemmerle-da mentioned this issue Jul 9, 2020
Merged
6 tasks
@remyhaemmerle-da remyhaemmerle-da added the component/daml-engine DAML-LF Engine & Interpreter label Aug 4, 2020
remyhaemmerle-da added a commit that referenced this issue Aug 4, 2020
@remyhaemmerle-da
DAML-LF: fix computation of global contract IDs for validation.
2acf1b4 
This PR fixes the computation of global contract IDS during
translation of transaction node to command for validation.

This follows the scheme described in daml-lf/spec/contract-id.rst

Extensive testing will be part of #6665.

CHANGELOG_BEGIN
CHANGELOG_END
@remyhaemmerle-da remyhaemmerle-da mentioned this issue Aug 4, 2020
Closed
6 tasks
remyhaemmerle-da added a commit that referenced this issue Oct 9, 2020
@remyhaemmerle-da
LF: Tests for Node.isReplayedBy
c77c72f 
This PR advances the state of #6665.

This test would have catch the bug fixed in #6664.

CHANGELOG_BEGIN
CHANGELOG_END
@remyhaemmerle-da remyhaemmerle-da mentioned this issue Oct 9, 2020
Closed
6 tasks
remyhaemmerle-da added a commit that referenced this issue Oct 9, 2020
@remyhaemmerle-da
LF: Tests for Node.isReplayedBy
8d3bd1f 
This PR advances the state of #6665.

This test would have catch the bug fixed in #6664.

CHANGELOG_BEGIN
CHANGELOG_END
@remyhaemmerle-da remyhaemmerle-da mentioned this issue Feb 4, 2021
Merged
6 tasks
This was referenced Aug 24, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@nickchapman-da nickchapman-da mentioned this issue Sep 2, 2021
Merged
@nickchapman-da nickchapman-da mentioned this issue Sep 15, 2021
Merged
@remyhaemmerle-da
Copy link
Collaborator Author

@nickchapman-da @cocreature I think we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/daml-engine DAML-LF Engine & Interpreter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cocreature @remyhaemmerle-da