Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass in interface ID to create-and-exercise, exercise-by-key commands #14549

Open
S11001001 opened this issue Jul 27, 2022 · 4 comments
Open

pass in interface ID to create-and-exercise, exercise-by-key commands #14549

S11001001 opened this issue Jul 27, 2022 · 4 comments
Labels
component/json-api HTTP JSON API roadmap/interfaces https://digitalasset.atlassian.net/browse/DAML-56 team/ledger-clients Related to the Ledger Clients team's components.

Comments

@S11001001
Copy link
Contributor

Spin-off of #14410. When #13653 introduces the optional interface ID to these commands, change CommandService.scala to pass in the interface ID as mentioned in TODOs in that file.

Note #13653 (comment) for upstream status.
@S11001001 S11001001 added component/json-api HTTP JSON API team/ledger-clients Related to the Ledger Clients team's components. labels Jul 27, 2022
stephencompall-DA pushed a commit that referenced this issue Jul 27, 2022
@S11001001
point to #14549 where appropriate, remove TODO we'll skip
34be558
@S11001001 S11001001 added the roadmap/interfaces https://digitalasset.atlassian.net/browse/DAML-56 label Aug 4, 2022
@S11001001 S11001001 mentioned this issue Aug 4, 2022
Closed
6 tasks
@ray-roestenburg-da
Copy link
Contributor

@S11001001 Is create-and-exercise with interface ID blocked, or just exercise-by-key?

@S11001001
Copy link
Contributor Author

@ray-roestenburg-da Both are blocked; each command needs the new field.

@ray-roestenburg-da
Copy link
Contributor

Thanks

@ray-roestenburg-da
Copy link
Contributor

Blocked until a choice_interface_id field is added to the gRPC service, this was discussed with @remyhaemmerle-da in our Zurich meeting but no further work has been done on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/json-api HTTP JSON API roadmap/interfaces https://digitalasset.atlassian.net/browse/DAML-56 team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@S11001001 @ray-roestenburg-da