Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Invalid JSON API schema after update #11251

Closed
stefanobaghino-da opened this issue Oct 14, 2021 · 0 comments · Fixed by #11252
Closed

[BUG] Invalid JSON API schema after update #11251

stefanobaghino-da opened this issue Oct 14, 2021 · 0 comments · Fixed by #11252
Assignees
Labels
component/json-api HTTP JSON API needs-backport Candidate fix for backporting to the latest release branch team/ledger-clients Related to the Ledger Clients team's components.

Comments

@stefanobaghino-da
Copy link
Contributor

I confirm that, if this is a bug that has security implications, I already contacted [email protected] and followed the responsible disclosure policy.

I confirm that this is not a question or a request for technical support by the community, for which the Daml forum is available.

Affected Daml version(s)
1.17.1 and 1.18 snapshot

Bug description
The schema is not correctly validated after a change as part of the transition from 1.17.x to 1.18.x

To reproduce
Start from a fresh database on 1.17.0, shut down, restart without creating the schema on 1.18 snapshot. The issue originally fixed by #11102 will still occur.

Expected behavior
Enter here a clear and concise description of what you expected to happen.

Workaround
The JSON API query store can be safely dropped and we can restart.

Additional context
Original fix: #11102
Backport to 1.17.1: #11143

@stefanobaghino-da stefanobaghino-da added component/json-api HTTP JSON API team/ledger-clients Related to the Ledger Clients team's components. needs-backport Candidate fix for backporting to the latest release branch labels Oct 14, 2021
@stefanobaghino-da stefanobaghino-da self-assigned this Oct 14, 2021
stefanobaghino-da added a commit that referenced this issue Oct 14, 2021
Closes #11251

Schema changed as part of #11102

Also backported to 1.17.1 in #11143

changelog_begin
[JSON API] Solving a bug that could cause the JSON API to return
correct result if a contract with the same key is observed twice
required a schema change. The JSON API data needs to be dropped
and the query store needs to reset. If you are migrating from a
previous version, either reset your database manually or start
the HTTP JSON API with one of the options that regenerate the
schema (`create-only`, `create-if-needed-and-start`, `create-and-start`).
changelog_end
stefanobaghino-da added a commit that referenced this issue Oct 15, 2021
Closes #11251

Schema changed as part of #11102

Also backported to 1.17.1 in #11143

changelog_begin
[JSON API] Solving a bug that could cause the JSON API to return
correct result if a contract with the same key is observed twice
required a schema change. The JSON API data needs to be dropped
and the query store needs to reset. If you are migrating from a
previous version, either reset your database manually or start
the HTTP JSON API with one of the options that regenerate the
schema (`create-only`, `create-if-needed-and-start`, `create-and-start`).
changelog_end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/json-api HTTP JSON API needs-backport Candidate fix for backporting to the latest release branch team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant