Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daml Interfaces PoC #10810

Closed
23 tasks done
cocreature opened this issue Sep 8, 2021 · 1 comment
Closed
23 tasks done

Daml Interfaces PoC #10810

cocreature opened this issue Sep 8, 2021 · 1 comment
Milestone
Daml Interfaces

Comments

@cocreature
Copy link
Contributor

cocreature commented Sep 8, 2021 •
edited
Loading

Will add details later for now I just need an issue number to reference in TODOs.

  • Protobuf
  • Haskell AST
  • Haskell typechecker
  • Support exercise on interface choice
  • Haskell name collision checker
  • Haskell protobuf decode & encode
  • Scala AST
  • Scala typechecker
  • Scala protobuf decode
  • Daml Parser
  • LF conversion
  • Speedy
  • Speedy compiler
  • Engine Preprocessor
  • Scala LF parser
  • Scala LF encoder
  • Add LF primitives for converting between interfaces & instances
  • Parse & desugar consuming declarations
  • Support interfaces in Daml Script’s exerciseCmd (and maybe more)
  • Support interfaces in Daml Triggers’s exerciseCmd (we probably get that for free via the previous point)
  • Consider how we represent interfaces in the typescript bindings
  • Consider implications of packages not being known upfront (at least for Daml Engine)
  • data-dependencies
@cocreature cocreature added this to the Daml Interfaces milestone Sep 8, 2021
remyhaemmerle-da added a commit that referenced this issue Sep 9, 2021
@remyhaemmerle-da
LF: add interface to scala AST and decoder
3e8c116 
this is part of #10810

CHANGELOG_BEGIN
CHANGELOG_END
@remyhaemmerle-da remyhaemmerle-da mentioned this issue Sep 9, 2021
Merged
6 tasks
remyhaemmerle-da added a commit that referenced this issue Sep 10, 2021
@remyhaemmerle-da
LF: add interface to scala AST and decoder (#10830)
e42cd3a 
this is part of #10810

CHANGELOG_BEGIN
CHANGELOG_END
@ghost ghost mentioned this issue Sep 14, 2021
Merged
6 tasks
cocreature added a commit that referenced this issue Sep 16, 2021
@cocreature
Separate exercise & fetch for interfaces from templates
feb5944 
part of #10810

changelog_begin
changelog_end
cocreature added a commit that referenced this issue Sep 16, 2021
@cocreature
Separate exercise & fetch for interfaces from templates
8156e5a 
part of #10810

changelog_begin
changelog_end
cocreature added a commit that referenced this issue Sep 16, 2021
@cocreature
Separate exercise & fetch for interfaces from templates
d126ee4 
part of #10810

changelog_begin
changelog_end
@cocreature cocreature mentioned this issue Sep 16, 2021
Merged
6 tasks
sofiafaro-da added a commit that referenced this issue Sep 16, 2021
@sofiafaro-da
Draft: Daml Interfaces Speedy PoC
c43f4ed 
Part of #10810
Extracted from #10670

changelog_begin
changelog_end
cocreature added a commit that referenced this issue Sep 16, 2021
@cocreature @sofiafaro-da
Separate exercise & fetch for interfaces from templates (#10908)
9b0fa29 
* Separate exercise & fetch for interfaces from templates

part of #10810

changelog_begin
changelog_end

* Update compiler/daml-lf-ast/src/DA/Daml/LF/Ast/Base.hs

Co-authored-by: Sofia Faro <[email protected]>

* Update compiler/daml-lf-ast/src/DA/Daml/LF/Ast/Base.hs

Co-authored-by: Sofia Faro <[email protected]>

Co-authored-by: Sofia Faro <[email protected]>
sofiafaro-da added a commit that referenced this issue Sep 16, 2021
@sofiafaro-da
Draft: Daml Interfaces Speedy PoC
3fe1636 
Part of #10810
Extracted from #10670

changelog_begin
changelog_end
mergify bot pushed a commit that referenced this issue Sep 17, 2021
@sofiafaro-da
Add fetch, exercise implementations for interfaces in speedy. (#10911)
61d214e 
* Draft: Daml Interfaces Speedy PoC

Part of #10810
Extracted from #10670

changelog_begin
changelog_end

* Improve cacheing situation, add implements checks

* scalafmt

* Add comment for ImplementsDefRef

* compile the new update expressions
sofiafaro-da added a commit that referenced this issue Sep 20, 2021
@sofiafaro-da
interfaces: Add to/from_interface in proto
82ac579 
Part of #10810

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Sep 20, 2021
Merged
6 tasks
mergify bot pushed a commit that referenced this issue Sep 20, 2021
@sofiafaro-da
interfaces: Add to/from_interface in proto (#10937)
409c0b4 
* interfaces: Add to/from_interface in proto

Part of #10810

changelog_begin
changelog_end

* fix typo
sofiafaro-da added a commit that referenced this issue Sep 20, 2021
@sofiafaro-da
interfaces: Add to/from interface in Haskell AST
3fa3a9a 
Part of #10810

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Sep 20, 2021
Merged
6 tasks
sofiafaro-da added a commit that referenced this issue Sep 21, 2021
@sofiafaro-da
interfaces: Add to/from interface in Haskell AST (#10945)
724e50d 
Part of #10810

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Sep 21, 2021
Merged
6 tasks
sofiafaro-da added a commit that referenced this issue Sep 21, 2021
@sofiafaro-da
interface: Add to/from interface in scala ast
7f269c3 
Part of #10810

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Sep 21, 2021
Merged
6 tasks
mergify bot pushed a commit that referenced this issue Sep 21, 2021
@sofiafaro-da
interface: Add to/from interface in scala ast (#10960)
d50df11 
Part of #10810

changelog_begin
changelog_end
sofiafaro-da added a commit that referenced this issue Sep 22, 2021
@sofiafaro-da
interfaces: Implemented conversions, added test.
4217ec0 
Part of #10810

- Implemented ToInterface, FromInterface in speedy
- Added a test that exercises and fetches an interface
- Fixed a bug in SBUChoiceInterface

Hey, interfaces work now!

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Sep 22, 2021
Merged
6 tasks
sofiafaro-da added a commit that referenced this issue Sep 22, 2021
@sofiafaro-da
interfaces: Implemented conversions, added test. (#10982)
34390f7 
Part of #10810

- Implemented ToInterface, FromInterface in speedy
- Added a test that exercises and fetches an interface
- Fixed a bug in SBUChoiceInterface

Hey, interfaces work now!

changelog_begin
changelog_end
sofiafaro-da added a commit that referenced this issue Sep 23, 2021
@sofiafaro-da
interface methods: Add protobuf
8035324 
Adds protobuf definitions for interface methods and calling them.
Encoders/decoders just ignore the extra stuff or error out.

Part of #10810 (maybe)

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Sep 23, 2021
Merged
6 tasks
sofiafaro-da added a commit that referenced this issue Sep 23, 2021
@sofiafaro-da
interface methods: Add protobuf definitions. (#11005)
bf8b75d 
* interface methods: Add protobuf

Adds protobuf definitions for interface methods and calling them.
Encoders/decoders just ignore the extra stuff or error out.

Part of #10810 (maybe)

changelog_begin
changelog_end

* Update issue numbers where appropriate

* update stable protos
remyhaemmerle-da added a commit that referenced this issue Sep 23, 2021
@remyhaemmerle-da
LF: Add interface support to the Preprocessor
a5b7f8e 
This is part of #10810

We handle only the case of Exercise as Fetch is currenlty used only by
Canton

CHANGELOG_BEGIN
CHANGELOG_END
@remyhaemmerle-da remyhaemmerle-da mentioned this issue Sep 23, 2021
Merged
6 tasks
remyhaemmerle-da added a commit that referenced this issue Sep 23, 2021
@remyhaemmerle-da
LF: Add interface support to the Preprocessor
7fa3a54 
This is part of #10810

We handle only the case of Exercise as Fetch is currenlty used only by
Canton

CHANGELOG_BEGIN
CHANGELOG_END
remyhaemmerle-da added a commit that referenced this issue Sep 23, 2021
@remyhaemmerle-da
LF: Add interface support to the Preprocessor
3bc3dc5 
This is part of #10810

We handle only the case of Exercise as Fetch is currenlty used only by
Canton

CHANGELOG_BEGIN
CHANGELOG_END
mergify bot pushed a commit that referenced this issue Sep 23, 2021
@remyhaemmerle-da
LF: Add interface support to the Preprocessor (#11013)
cb0e41f 
This is part of #10810

We handle only the case of Exercise as Fetch is currenlty used only by
Canton

CHANGELOG_BEGIN
CHANGELOG_END
@ghost ghost mentioned this issue Oct 5, 2021
Merged
6 tasks
@sofiafaro-da sofiafaro-da mentioned this issue Oct 13, 2021
Merged
7 tasks
sofiafaro-da added a commit that referenced this issue Nov 4, 2021
@sofiafaro-da
interfaces: Improve fixed choice lookup
59a566f 
This PR adds a lazy map to match fixed choice names to their
interface, to improve the worst case for choice lookup.

Part of #10810

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Nov 4, 2021
Merged
7 tasks
sofiafaro-da added a commit that referenced this issue Nov 4, 2021
@sofiafaro-da
interfaces: Improve fixed choice lookup (#11551)
4d4869f 
* interfaces: Improve fixed choice lookup

This PR adds a lazy map to match fixed choice names to their
interface, to improve the worst case for choice lookup.

Part of #10810

changelog_begin
changelog_end

* scalafmt

* apply improvements from remy
akrmn added a commit that referenced this issue Nov 8, 2021
@akrmn
Disable failing interface tests with TODO #10810
d338add
akrmn added a commit that referenced this issue Nov 8, 2021
@akrmn
Disable failing interface tests with TODO #10810
e07186d
@cocreature
Copy link
Contributor Author

I think this issue has served its purpose, closing in favor of more specific ones.

akrmn added a commit that referenced this issue Nov 8, 2021
@akrmn
Remove virtual choices (#11482)
7d68e05 
* Remove virtual choices

* Remove choices without a body in 'interface' definition
* Remove choices in 'template ... implements' section

part of #11372

changelog_begin
changelog_end

* Remove virtual choices cont.

Switch uses of virtual choices to fixed choice with method implementation

* update snapshot after pin on windows

* Disable failing interface tests with TODO #10810
sofiafaro-da added a commit that referenced this issue Nov 25, 2021
@sofiafaro-da
Add a ContractDoesntImplementInterface error
b052714 
Part of #10810 and #11703

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Nov 25, 2021
Merged
7 tasks
sofiafaro-da added a commit that referenced this issue Nov 29, 2021
@sofiafaro-da
Add ContractDoesntImplementInterface error. (#11884)
0b9d57b 
* Add a ContractDoesntImplementInterface error

Part of #10810 and #11703

changelog_begin
changelog_end

* use inside

* rename error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Daml Interfaces
Development

No branches or pull requests
1 participant
@cocreature