Skip to content

Commit

Permalink
Fix damlc warnings & compile flags (#12404)
Browse files Browse the repository at this point in the history
`--ghc-option=-Werror` turns warnings into errors, `--ghc-option=-Wwarn`
undoes exactly that so this clearly was not doing anything sensible.

changelog_begin
changelog_end
  • Loading branch information
cocreature authored Jan 13, 2022
1 parent b21c960 commit ce62491
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
-- Copyright (c) 2022 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
-- SPDX-License-Identifier: Apache-2.0

{-# OPTIONS -Wno-controller-can #-}

module Stakeholders where

Expand Down
2 changes: 0 additions & 2 deletions ledger/test-common/src/main/daml/semantic/TimeTests.daml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@

module TimeTests where

import DA.Time

template TimeChecker
with
party: Party
Expand Down
4 changes: 2 additions & 2 deletions rules_daml/daml.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ _daml_build = rule(
),
"ghc_options": attr.string_list(
doc = "Options passed to GHC.",
default = ["--ghc-option=-Werror", "--ghc-option=-Wwarn", "--log-level=WARNING"],
default = ["--ghc-option=-Werror", "--log-level=WARNING"],
),
"damlc": _damlc,
},
Expand Down Expand Up @@ -256,7 +256,7 @@ _inspect_dar = rule(

_default_project_version = "1.0.0"

default_damlc_opts = ["--ghc-option=-Werror", "--ghc-option=-Wwarn", "--log-level=WARNING"]
default_damlc_opts = ["--ghc-option=-Werror", "--log-level=WARNING"]

def damlc_for_target(target):
if not target or target in COMPILER_LF_VERSIONS:
Expand Down

0 comments on commit ce62491

Please sign in to comment.