Skip to content

Commit

Permalink
Upgrade to NodeJS 14
Browse files Browse the repository at this point in the history
NodeJS 12 is eol in April and there are already packages (e.g. vsce)
that dropped support. We probably should upgrade even further but for
now I’m going with the most conservative approach.

changelog_begin
changelog_end
  • Loading branch information
cocreature committed Jan 17, 2022
1 parent 952a939 commit 7001120
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .dadew
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"ojdkbuild11",
"maven-3.6.1",
"msys2",
"nodejs-12.17.0",
"nodejs",
"nsis-3.04",
"python-3.8.2",
"stack",
Expand Down
2 changes: 1 addition & 1 deletion WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ dev_env_tool(
".",
],
win_paths = [],
win_tool = "nodejs-12.17.0",
win_tool = "nodejs",
)

# Setup the Node.js toolchain
Expand Down
2 changes: 1 addition & 1 deletion compatibility/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ dev_env_tool(
".",
],
win_paths = [],
win_tool = "nodejs-12.17.0",
win_tool = "nodejs",
)

node_repositories(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
{
"homepage": "https://nodejs.org",
"description": "As an asynchronous event driven JavaScript runtime, Node is designed to build scalable network applications. (Long Term Support)",
"version": "12.17.0",
"version": "14.18.3",
"license": "MIT",
"architecture": {
"64bit": {
"url": "https://nodejs.org/dist/v12.17.0/node-v12.17.0-win-x64.7z",
"hash": "1749c9dcfceb29ad0c6ffa447f86d96efec8f97823b3b5e17940de9043113ca3",
"extract_dir": "node-v12.17.0-win-x64"
"url": "https://nodejs.org/dist/v14.18.3/node-v14.18.3-win-x64.7z",
"hash": "456f3d26f900dbf0221b311884e81926b4aea96d75e57b30ab6cb142d05e10d9",
"extract_dir": "node-v14.18.3-win-x64"
},
"32bit": {
"url": "https://nodejs.org/dist/v12.17.0/node-v12.17.0-win-x86.7z",
"hash": "d79026437e764fa090b562ca504dd6596601105b14fc564d54da4e23a1f52c06",
"extract_dir": "node-v12.17.0-win-x86"
"url": "https://nodejs.org/dist/v14.18.3/node-v14.18.3-win-x86.7z",
"hash": "a7ec2f7d8a5973869eebae31f24d859bfb363bb9df8ad19404ff28b84784c0e1",
"extract_dir": "node-v14.18.3-win-x86"
}
},
"persist": [
Expand Down
2 changes: 1 addition & 1 deletion nix/nixpkgs.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ let

# package overrides
overrides = _: pkgs: rec {
nodejs = pkgs.nodejs-12_x;
nodejs = pkgs.nodejs-14_x;
ephemeralpg = pkgs.ephemeralpg.overrideAttrs(oldAttrs: {
installPhase = ''
mkdir -p $out
Expand Down
2 changes: 1 addition & 1 deletion release/RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ patches we backport to the 1.0 release branch).
- Just the bare install; no need to build C dependencies.
- `create-daml-app` doesn't work with the latest version 17.x of node.js.
If you have `nix` installed, you can use a suitable version of nodejs by
running `nix-shell -p nodejs-12_x` before running the `npm` commands below.
running `nix-shell -p nodejs-14_x` before running the `npm` commands below.

1. Run `daml version --assistant=yes` and verify that the new version is
selected as the assistant version and the default version for new projects.
Expand Down

0 comments on commit 7001120

Please sign in to comment.