[DPP-676][Self-service error codes] Adapt ApiConfigManagementService

CHANGELOG_BEGIN CHANGELOG_END
digital-asset · Oct 27, 2021 · 411d3ab · 411d3ab
1 parent 3031190
commit 411d3ab
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/...mon/src/main/scala/com/digitalasset/platform/server/api/validation/FieldValidations.scala b/...mon/src/main/scala/com/digitalasset/platform/server/api/validation/FieldValidations.scala
@@ -190,10 +190,7 @@ class FieldValidations private (errorFactories: ErrorFactories) {
 
 }
 
-/** Default implementation exposing field validations with the legacy error factories.
-  * TODO error codes: Remove default implementation once all consumers output versioned error codes.
-  */
-object FieldValidations extends FieldValidations(ErrorFactories) {
+object FieldValidations {
   def apply(errorFactories: ErrorFactories): FieldValidations =
     new FieldValidations(errorFactories)
 }
diff --git a/...ion-api/src/main/scala/platform/apiserver/services/admin/ApiConfigManagementService.scala b/...ion-api/src/main/scala/platform/apiserver/services/admin/ApiConfigManagementService.scala
@@ -25,8 +25,8 @@ import com.daml.logging.{ContextualizedLogger, LoggingContext}
 import com.daml.platform.api.grpc.GrpcApiService
 import com.daml.platform.apiserver.services.admin.ApiConfigManagementService._
 import com.daml.platform.apiserver.services.logging
-import com.daml.platform.server.api.validation.ErrorFactories
-import com.daml.platform.server.api.{ValidationLogger, validation}
+import com.daml.platform.server.api.ValidationLogger
+import com.daml.platform.server.api.validation.{ErrorFactories, FieldValidations}
 import com.daml.telemetry.{DefaultTelemetry, TelemetryContext}
 import io.grpc.{ServerServiceDefinition, StatusRuntimeException}
 
@@ -52,6 +52,7 @@ private[apiserver] final class ApiConfigManagementService private (
     new DamlContextualizedErrorLogger(logger, loggingContext, None)
 
   private val errorFactories = ErrorFactories(errorCodesVersionSwitcher)
+  private val fieldValidations = FieldValidations(errorFactories)
 
   import errorFactories._
 
@@ -172,7 +173,7 @@ private[apiserver] final class ApiConfigManagementService private (
   )(implicit
       contextualizedErrorLogger: ContextualizedErrorLogger
   ): Either[StatusRuntimeException, SetTimeModelParameters] = {
-    import validation.FieldValidations._
+    import fieldValidations._
     for {
       pTimeModel <- requirePresence(request.newTimeModel, "new_time_model")
       pAvgTransactionLatency <- requirePresence(