DPP-650 Remove the mutating schema (#11211)

* Remove the mutating schema

changelog_begin
- [Participant] All participants now use the new append-only schema. Existing databases will
  automatically upgrade to the new schema the first time a participant/ledger is started.
changelog_end

* Fix post-commit validation test

* Remove append-only flags from CI

* Don't crash when using deprecated flag

* Increase timeout for reset service tests

* Fix typos in parameter names

* Restore removed test

* Restore removed CLI check

* Improve CLI parameter description

daml-script/export/integration-tests/export-lf-1.6/BUILD.bazel

@@ -65,7 +65,6 @@ client_server_build(
         "--ledgerid=lf16-export-ledger",
         "--port=0",
         "--port-file=%PORT_FILE%",
-        "--enable-append-only-schema",
     ],
     server_files = ["lf16.build"],
 )

daml-script/export/integration-tests/matches-docs/BUILD.bazel

@@ -53,7 +53,6 @@ client_server_build(
     server_args = [
         "--port=0",
         "--port-file=%PORT_FILE%",
-        "--enable-append-only-schema",
     ],
     server_files = ["//daml-script/test:script-test.dar"],
 )

ledger/daml-on-sql/BUILD.bazel

@@ -109,7 +109,6 @@ conformance_test(
         "--ledgerid=conformance-test",
         "--port=6865",
         "--eager-package-loading",
-        "--enable-append-only-schema",
     ],
     test_tool_args = [
         "--verbose",

ledger/indexer-benchmark/src/main/scala/ledger/indexerbenchmark/Config.scala

@@ -36,7 +36,6 @@ object Config {
       participantId = Ref.ParticipantId.assertFromString("IndexerBenchmarkParticipant"),
       jdbcUrl = "",
       startupMode = IndexerStartupMode.MigrateAndStart,
-      enableAppendOnlySchema = true,
     ),
     waitForUserInput = false,
     minUpdateRate = None,

ledger/indexer-benchmark/src/main/scala/ledger/indexerbenchmark/IndexerBenchmark.scala

@@ -20,7 +20,6 @@ import com.daml.lf.data.Time
 import com.daml.logging.LoggingContext
 import com.daml.logging.LoggingContext.newLoggingContext
 import com.daml.metrics.{JvmMetricSet, Metrics}
-import com.daml.platform.configuration.ServerRole
 import com.daml.platform.indexer.{JdbcIndexer, StandaloneIndexerServer}
 import com.daml.platform.store.LfValueTranslationCache
 import com.daml.testing.postgresql.PostgresResource
@@ -70,7 +69,6 @@ class IndexerBenchmark() {
       println("Creating read service and indexer...")
       val readService = createReadService(updates)
       val indexerFactory = new JdbcIndexer.Factory(
-        ServerRole.Indexer,
         config.indexerConfig,
         readService,
         indexerEC,
@@ -91,8 +89,7 @@ class IndexerBenchmark() {
           .result(
             StandaloneIndexerServer
               .migrateOnly(
-                jdbcUrl = config.indexerConfig.jdbcUrl,
-                enableAppendOnlySchema = config.indexerConfig.enableAppendOnlySchema,
+                jdbcUrl = config.indexerConfig.jdbcUrl
               )
               .map(_ => indexerFactory.initialized())(indexerEC),
             Duration(5, "minute"),
@@ -135,7 +132,6 @@ class IndexerBenchmark() {
              |  jdbcUrl:  ${config.indexerConfig.jdbcUrl}
              |
              |Indexer parameters:
-             |  enableAppendOnlySchema:    ${config.indexerConfig.enableAppendOnlySchema}
              |  maxInputBufferSize:        ${config.indexerConfig.maxInputBufferSize}
              |  inputMappingParallelism:   ${config.indexerConfig.inputMappingParallelism}
              |  ingestionParallelism:      ${config.indexerConfig.ingestionParallelism}

ledger/ledger-on-memory/BUILD.bazel

@@ -146,7 +146,6 @@ conformance_test(
         "--contract-id-seeding=testing-weak",
         "--participant=participant-id=example,port=6865",
         "--max-deduplication-duration=PT5S",
-        "--index-append-only-schema",
         "--mutable-contract-state-cache",
     ],
     test_tool_args = [
@@ -175,7 +174,6 @@ conformance_test(
         "--participant=participant-id=example,port=6865",
         "--daml-lf-min-version-1.14-unsafe",
         "--max-deduplication-duration=PT5S",
-        "--index-append-only-schema",
         "--mutable-contract-state-cache",
     ],
     test_tool_args = [
@@ -195,7 +193,6 @@ conformance_test(
     server = ":app",
     server_args = [
         "--contract-id-seeding=testing-weak",
-        "--index-append-only-schema",
         "--mutable-contract-state-cache",
         "--participant=participant-id=example1,port=6865",
         "--participant=participant-id=example2,port=6866",
@@ -223,7 +220,6 @@ conformance_test(
     server = ":app",
     server_args = [
         "--contract-id-seeding=testing-weak",
-        "--index-append-only-schema",
         "--mutable-contract-state-cache",
         "--participant=participant-id=split-example,port=6865,server-jdbc-url=jdbc:h2:mem:split-example;db_close_delay=-1;db_close_on_exit=false,shard-name=server1,run-mode=ledger-api-server",
         "--participant=participant-id=split-example,port=6865,server-jdbc-url=jdbc:h2:mem:split-example;db_close_delay=-1;db_close_on_exit=false,shard-name=indexer,run-mode=indexer",
@@ -250,7 +246,6 @@ conformance_test(
     server_args = [
         "--contract-id-seeding=testing-weak",
         "--participant=participant-id=example,port=6865",
-        "--index-append-only-schema",
         "--mutable-contract-state-cache",
     ],
     test_tool_args = [

ledger/ledger-on-sql/BUILD.bazel

@@ -258,7 +258,6 @@ da_scala_test_suite(
                 "--contract-id-seeding=testing-weak",
                 "--participant participant-id=conformance-test,port=6865",
                 "--max-deduplication-duration=PT5S",
-                "--index-append-only-schema",
                 "--mutable-contract-state-cache",
             ] + db.get("conformance_test_server_args", []),
             tags = db.get("conformance_test_tags", []),
@@ -279,7 +278,6 @@ da_scala_test_suite(
             server_args = [
                 "--contract-id-seeding=testing-weak",
                 "--participant participant-id=example,port=6865",
-                "--index-append-only-schema",
                 "--mutable-contract-state-cache",
             ] + db.get("conformance_test_server_args", []),
             tags = db.get("benchmark_performance_envelope_tags", []),
@@ -315,7 +313,6 @@ conformance_test(
     server_args = [
         "--contract-id-seeding=testing-weak",
         "--participant participant-id=conformance-test,port=6865,contract-state-cache-max-size=1,contract-key-state-cache-max-size=1",
-        "--index-append-only-schema",
         "--mutable-contract-state-cache",
         "--max-deduplication-duration=PT5S",
     ],
@@ -342,7 +339,6 @@ conformance_test(
     server_args = [
         "--contract-id-seeding=testing-weak",
         "--participant participant-id=conformance-test,port=6865,contract-state-cache-max-size=1,contract-key-state-cache-max-size=1",
-        "--index-append-only-schema",
         "--mutable-contract-state-cache",
         "--jdbc-url=jdbc:h2:mem:daml-on-sql-conformance-test",
         "--max-deduplication-duration=PT5S",
@@ -370,7 +366,6 @@ conformance_test(
     server_args = [
         "--contract-id-seeding=testing-weak",
         "--participant participant-id=conformance-test,port=6865,contract-state-cache-max-size=1,contract-key-state-cache-max-size=1",
-        "--index-append-only-schema",
         "--mutable-contract-state-cache",
         "--max-deduplication-duration=PT5S",
     ],
@@ -397,7 +392,6 @@ conformance_test(
     server_args = [
         "--contract-id-seeding=testing-weak",
         "--participant participant-id=conformance-test,port=6865,contract-state-cache-max-size=1,contract-key-state-cache-max-size=1,ledger-api-transactions-buffer-max-size=10",
-        "--index-append-only-schema",
         "--mutable-contract-state-cache",
         "--buffered-ledger-api-streams-unsafe",
         "--max-deduplication-duration=PT5S",
@@ -419,13 +413,12 @@ conformance_test(
 
 # Feature test: --buffered-ledger-api-streams-unsafe (in-memory fan-out) (Oracle)
 conformance_test(
-    name = "conformance-test-append-only-in-memory-fan-out-oracle",
+    name = "conformance-test-in-memory-fan-out-oracle",
     ports = [6865],
     server = ":conformance-test-oracle-bin",
     server_args = [
         "--contract-id-seeding=testing-weak",
         "--participant participant-id=conformance-test,port=6865,contract-state-cache-max-size=1,contract-key-state-cache-max-size=1,ledger-api-transactions-buffer-max-size=10",
-        "--index-append-only-schema",
         "--mutable-contract-state-cache",
         "--buffered-ledger-api-streams-unsafe",
         "--max-deduplication-duration=PT5S",
@@ -455,7 +448,6 @@ conformance_test(
     server_args = [
         "--contract-id-seeding=testing-weak",
         "--participant participant-id=conformance-test,port=6865,contract-state-cache-max-size=1,contract-key-state-cache-max-size=1",
-        "--index-append-only-schema",
         "--mutable-contract-state-cache",
         "--jdbc-url=jdbc:h2:mem:daml-on-sql-conformance-test",
     ],