Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade packages #367

Merged
merged 1 commit into from
Jan 6, 2022
Merged

upgrade packages #367

merged 1 commit into from
Jan 6, 2022

Conversation

simenstoa
Copy link
Contributor

@simenstoa simenstoa commented Dec 23, 2021

Upgrade dotnet packages from 5 to 6. This made Program stop running with dotnet core 2.1, so i guess this is a breaking change?

@simenstoa
Copy link
Contributor Author

Ref #365

@runeflobakk
Copy link
Member

As someone who is not versed with .NET, should it be OK to bump the required dotnet core version? What will be the new minimum version? Is the upgrade trivial for any existing integrations still on dotnet core 2.1, if any?
If there is a known vulnerability in v5 of those packages, and Microsoft does not have any intention of fixing them, I guess they should be considered dead anyway, so bumping the minimum version of Core seems necessary. And I guess that mandates a new major version.

@simenstoa
Copy link
Contributor Author

Dotnet core 2.1 had end of life in August 2021, so it's no longer supported by Microsoft either: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core

So I think it's ok that we release a new major version that does not support it.

@hanskhe
Copy link
Contributor

hanskhe commented Jan 6, 2022

We should be able to drop support for Dotnet Core 2.1 without issue. As pointed out, it is no longer in support.

I agree with Rune, this would mandate a new major version release.

@simenstoa simenstoa merged commit f2daf16 into master Jan 6, 2022
@simenstoa simenstoa deleted the upgrade-packages branch January 6, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants