Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prefix the full subvolume path in snapshot_name #342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LubosKolouch
Copy link

No description provided.

@digint
Copy link
Owner

digint commented Nov 1, 2020

i'm not sure if this completely implements it, looks promising though.
I suspect there might be other places in the code which rely on simple $snapshot_name. not sure though, will have to look at it in detail.

@digint
Copy link
Owner

digint commented Dec 26, 2020

I've had closer look at it, and I fear your fix only solves part of the problem.

probably patch the path in early (directly in parse_config_line) seems the better approach to me.
Leaving the merge request open for now, as this feature still seems very useful to me.

@digint digint changed the title Proposed implementation for https://github.com/digint/btrbk/issues/304 Add option to prefix the full subvolume path in snapshot_name Dec 26, 2020
@digint digint force-pushed the master branch 6 times, most recently from 594fc6d to dac6350 Compare August 5, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants