Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto build image in GitHub #113

Closed
wants to merge 1 commit into from
Closed

Auto build image in GitHub #113

wants to merge 1 commit into from

Conversation

digininja
Copy link
Owner

GitHub will now automatically build the image so I've updated the README to use this image rather than build it locally.

GitHub will now automatically build the image so I've updated the README
to use this image rather than build it locally.
@digininja
Copy link
Owner Author

@loris-intergalactique Can you have a quick look at this and sanity check it.

I've got GitHub automatically building the image so I've updated your instructions so it pulls the image from the repo rather than building it locally. It seems to work for me but this is only the second time I've done this so not 100% sure if it is the right way to do things.

Copy link
Contributor

@loris-intergalactique loris-intergalactique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here we should chose to either explain people how to build it, and/or explain people how to use the ghcr.io/digininja/cewl image.

If you want to keep the building instructions, this section can stay as it is because it is correct (changing it with compose is not technically locally building it, and overkill) and we can add another section about using ghcr.io/digininja/cewl.

If you don't really want to keep the build instruction, we can change the whole content of this to "just use docker run -it --rm ghcr.io/digininja/cewl http://dvwa.test".

Personally, I think it is not our job to educate people on how to use docker, so we can just add one or two docker run lines. The one explaining how to use volumes is mostly here for script kiddies. We do not need the compose.yml file.

Do you want me to make a PR to do this change?

@digininja
Copy link
Owner Author

I should have known there would be a better way to do it!

Go for the PR and I'll see how you do it.

@loris-intergalactique
Copy link
Contributor

Can be replaced by #114

@digininja
Copy link
Owner Author

Boo, what fool wrote this, rejecting it.

@digininja digininja closed this May 3, 2024
@loris-intergalactique
Copy link
Contributor

loris-intergalactique commented May 3, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants