feat: Setting to choose coordinate display format #526

luandro · 2021-03-16T23:12:08Z

This adds the ability to change the coordinate system, saving to AsyncStorage the selected option.

Add coordinate system page to settings with ability to change between LatLon, UTM, DMS, DD
Change coords on observation screens based on setting
Change coords on GPS screen based on setting

…etween LatLon, UTM, DMS, DD

hackergrrl · 2021-03-17T18:34:13Z

I don't feel super qualified to review this, but it looks good to me! If it all seems to be working in your manual tests, I think it's ok to merge now.

cc @gmaclennan to take a look over when he's back.

gmaclennan · 2021-03-23T15:57:18Z

Hi! I'm back! Great work on this @luandro! I haven't installed this or checked the code yet, but based purely on the screenshots a couple of comments:

"Latitude and Longitude" and "Decimal Degrees" are the same thing. DMS is also Latitude and Longitude. Basically DMS and Decimal Degrees are two ways or writing lat & lon.
I think we should round decimal degrees to 6 decimal places (see https://wiki.openstreetmap.org/wiki/Precision_of_coordinates). That is about 10cm precision at the equator, which is way more than our GPS precision anyway.
Just to make sure that we show decimals on DMS coordinates, e.g. 0°00′00.004″. We should show 3 decimal places here to match the same precision as DD.
There are lots of ways to format / write DMS (see https://github.com/gmaclennan/parse-dms/blob/master/test/index.js) but I think DD°MM′SS.sss″ N DD°MM′SS.sss″ W makes the most sense. Latitude is first when writing DMS (most of the time!)
There is controversy about whether to write decimal degrees as lon/lat or lat/lon. The "traditionalists" say lat/lon, which is "y-axis" first, but most computer code expects Longitude first (e.g. x-axis first). I would lean towards lon first. Not sure what the best way is to format this so that it is clear to the user, could you do some research into ways of formatting / writing decimal degrees?

gmaclennan · 2021-03-23T16:00:28Z

Also we should put this data (selected coordinate system) in React Context, and the hook should read from there. I can talk through the reasons for this and how to do this on our next check-in.

luandro · 2021-03-24T22:57:46Z

"Latitude and Longitude" and "Decimal Degrees" are the same thing. DMS is also Latitude and Longitude. Basically DMS and Decimal Degrees are two ways or writing lat & lon.

lol thanks, was really confused that both looked exactly the same.

I think we should round decimal degrees to 6 decimal places

Makes a lot of sense.

Just to make sure that we show decimals on DMS coordinates, e.g. 0°00′00.004″. We should show 3 decimal places here to match the same precision as DD.

👍

could you do some research into ways of formatting / writing decimal degrees?

In relation to what comes first (lat or long):

My interpratation:

Lat/Long is commonly used because Latitute was discovered first, as has been used first since.

Long/Lat is also commonly used because of conventional math (ie, f(x ,y, z)).

I think lat/long will make more sense for the user, while long/lat will make more sense for a machine. Thoughts @gmaclennan, as you have more experience? @rudokemper might also have some thought on this.

rudokemper · 2021-03-24T23:22:16Z

In my experience, latitude is generally always written out first, conforming to your observations on user expectations @luandro. But that might be specific to the contexts where I have done GIS work (Suriname, Brazil, Colombia, and now Kenya). But even experienced GIS specialists get lat & long confused all the time, and have to look up which is which, haha..

src/frontend/lib/utils.js

luandro · 2021-03-25T22:11:03Z

Todo:

Add settings context, and have the coordinate config live there
Rename LatLog to Decimal Degrees
Pass lat lon as object to coordinate format functions

Forgetting anything @gmaclennan?

luandro · 2021-04-01T13:19:37Z

Had a bit of a hard time updating my knowledge on React hooks, but all worked out. Ready for another review @gmaclennan.

gmaclennan

Adding my feedback here that I shared over Slack, so there's a record of it. I've fixed this up myself and I'm just testing locally before pushing.

gmaclennan · 2021-04-16T17:03:35Z

src/frontend/context/SettingsContext.js

+const defaultContext = [initialState, () => {}];
+const SettingsContext = React.createContext(defaultContext);
+
+function reducer(state: State, action: Action): State {
+  switch (action.type) {
+    case "set": {
+      return action.value;
+    }
+    case "set_coordinate_system": {
+      try {
+        return { ...state, coordinateSystem: action.value };
+      } catch {
+        return state;
+      }
+    }
+    default:
+      return state;
+  }
+}
+
+const getData = async dispatch => {
+  try {
+    // AsyncStorage.clear()
+    const state = await AsyncStorage.getItem(STORE_KEY);
+    if (state) {
+      const parsedState = JSON.parse(state);
+      dispatch({ type: "set", value: parsedState });
+      return parsedState;
+    } else return initialState;
+  } catch (e) {
+    console.log("Failed to fetch the data from storage");
+    return initialState;
+  }
+};
+
+const saveData = async value => {
+  try {
+    const stringified = JSON.stringify(value);
+    await AsyncStorage.setItem(STORE_KEY, stringified);
+    return value;
+  } catch (e) {
+    console.log("Failed to save the data to the storage");
+  }
+};
+


There is already a usePersistedState hook, so best use that rather than have two different implementations of this.

gmaclennan · 2021-04-16T17:03:53Z

src/frontend/context/SettingsContext.js

+  }, [contextValue]);
+  return (
+    <SettingsContext.Provider
+      value={{ settings: contextValue[0], dispatch: contextValue[1] }}


This creates a new object on every render

gmaclennan · 2021-04-16T17:04:14Z

src/frontend/lib/utils.js

+  const formattedSeconds = Number(
+    Math.round(seconds + "e" + decimals) + "e-" + decimals
+  );


Why not seconds.toFixed(3)?

gmaclennan · 2021-04-16T17:06:19Z

src/frontend/sharedComponents/LocationField.js

@@ -55,6 +58,7 @@ const LocationField = ({ children }: Props) => {
  return children({
    longitude: value.lon,
    latitude: value.lat,
+    system: coordinateSystem,


This doesn't really belong here, because this component has nothing to do with the display of coordinates. To separate concerns, I think it's better to keep this in the <LocationView> component

* develop: feat: Setting to choose coordinate display format (#526) chore: Re-apply c267a99 with correct npm@6 version and lockfile v1 Revert "feat: Updated translations for default configuration (vi, srn)" feat: Updated translations for default configuration (vi, srn) fix: Update Thai, Khmer & Vietnamese translations feat: Add Dutch translations feat: Add Sranan Tongo translations feat: Add French translations fix: Fix cutoff of text on OnePlus6T phone #502 (#511) fix: Write preset tags to observations (#514) chore: Fix Github CI builds by removing NDK r22 (#516) fix: Fix import config button crash (#512) feat: Updated translations (vi, es, po) (#498) # Conflicts: # src/backend/package-lock.json # src/backend/package.json # src/frontend/screens/Settings/Settings.js

luandro added 4 commits March 16, 2021 20:10

feat: Add coordinate system page to settings with ability to change b…

2736f57

…etween LatLon, UTM, DMS, DD

fix: Add latlon to formatCoords switch

cf4be4f

feat: Add information on GpsModal based on selected coordinate system

81953d0

feat: Show coordinates on observation screens based on selected system

330c882

luandro marked this pull request as ready for review March 17, 2021 12:11

fix: Add value check before setting AsyncStorage

32fbe0a

luandro added 5 commits March 24, 2021 18:06

fix: Have Coordinate System before About Mapeo on configuration menu

2c07212

fix: Remove Decimal Degrees which is same as Lat Long

f853030

fix: Round decimal degrees to 6 decimal places

873a6b5

chore: Cleanup and add better formating for DMS

48e815b

fix: Add 3 decimal degrees to DMS coordinates

930346b

gmaclennan reviewed Mar 25, 2021

View reviewed changes

src/frontend/lib/utils.js Outdated Show resolved Hide resolved

luandro added 4 commits March 26, 2021 14:44

fix: Pass lat/lon explicitly within an object on formatting functions

70b3d1c

fix: Use Decimal Degrees naming instead of lat/lon

31c127a

chore: Extract messages and add DD to naming in config menu

72fa39e

chore: Add settings context

e4ee80d

luandro requested a review from gmaclennan April 1, 2021 13:19

chore: Update screens and components to use settings context

4caa862

gmaclennan reviewed Apr 16, 2021

View reviewed changes

gmaclennan added 4 commits April 16, 2021 18:23

fixes & cleanup

d4499e8

remove unused message

a41fddf

Update language to coordinate format

9e8eeaa

Use Number.toFixed() for rounding coordinates

4b15d25

Merge branch 'develop' into custom-coord-system

ecc7245

gmaclennan changed the title ~~Custom coordinate system~~ feat: Allow user to choose the format coordinates are displayed in Apr 16, 2021

gmaclennan changed the title ~~feat: Allow user to choose the format coordinates are displayed in~~ feat: Choose the format coordinates are displayed in Apr 16, 2021

gmaclennan changed the title ~~feat: Choose the format coordinates are displayed in~~ feat: Setting to choose coordinate display format Apr 16, 2021

gmaclennan added 3 commits April 16, 2021 19:43

Fix flow type error

46fe030

Add comma to DMS formatting

fa8a738

Format lat/long DD according to Nat Geo style guide

7e02d19

gmaclennan merged commit 567fcce into develop Apr 19, 2021

gmaclennan deleted the custom-coord-system branch April 19, 2021 18:03

achou11 mentioned this pull request Sep 27, 2021

Release v5.3.0 #750

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Setting to choose coordinate display format #526

feat: Setting to choose coordinate display format #526

luandro commented Mar 16, 2021 •

edited

Loading

hackergrrl commented Mar 17, 2021

gmaclennan commented Mar 23, 2021

gmaclennan commented Mar 23, 2021

luandro commented Mar 24, 2021

rudokemper commented Mar 24, 2021

luandro commented Mar 25, 2021 •

edited

Loading

luandro commented Apr 1, 2021

gmaclennan left a comment

gmaclennan Apr 16, 2021

gmaclennan Apr 16, 2021

gmaclennan Apr 16, 2021

gmaclennan Apr 16, 2021

feat: Setting to choose coordinate display format #526

feat: Setting to choose coordinate display format #526

Conversation

luandro commented Mar 16, 2021 • edited Loading

hackergrrl commented Mar 17, 2021

gmaclennan commented Mar 23, 2021

gmaclennan commented Mar 23, 2021

luandro commented Mar 24, 2021

rudokemper commented Mar 24, 2021

luandro commented Mar 25, 2021 • edited Loading

luandro commented Apr 1, 2021

gmaclennan left a comment

Choose a reason for hiding this comment

gmaclennan Apr 16, 2021

Choose a reason for hiding this comment

gmaclennan Apr 16, 2021

Choose a reason for hiding this comment

gmaclennan Apr 16, 2021

Choose a reason for hiding this comment

gmaclennan Apr 16, 2021

Choose a reason for hiding this comment

luandro commented Mar 16, 2021 •

edited

Loading

luandro commented Mar 25, 2021 •

edited

Loading