Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add empty offline map so that points still show if no custom map #448

Merged
merged 5 commits into from
Sep 11, 2020

Conversation

gmaclennan
Copy link
Member

@gmaclennan gmaclennan commented Aug 7, 2020

Previously, if Mapeo was offline and the user had not installed an offline map, then no map would show and no points would show.

This PR adds a default offline map with country boundaries, land and ocean, rivers and lakes, and a graticule grid of 0.1°. Currently the offline map data is shipped as geojson via the package mapeo-offline-map, which means that all the data is loaded into memory, so we need to keep it small. The current offline map uses simplified data from https://www.naturalearthdata.com. The graticule is included because when the user is zoomed in, no other features are present, so the graticule overlay helps give the user the sense that pan and zoom interactions are working.

mapeo-offline-map-example

Download a QA build of this PR#448

TODO:

  • Inset maps in ObservationView do not work

Fixes #379

Also refactors the useStyleURL hook to be more explicit
@gmaclennan gmaclennan merged commit f7c32b2 into develop Sep 11, 2020
@gmaclennan gmaclennan deleted the feat/empty-offline-map branch September 11, 2020 13:35
gmaclennan added a commit that referenced this pull request Sep 24, 2020
* feat/preset-translations:
  fix: Fix package-lock (was causing build to fail)
  chore: cleanup and code comments
  chore: abstract obs date formatter & move formatters to single file
  fix: Use translated preset name in ObservationList
  fix: Correctly translate and display field values in share message
  feat: Translate presets
  chore: Update deps
  chore: Fix flow types for component style
  feat: Add empty offline map so that points still show if no custom map (#448)
  feat: Add translations (es, vi, th) (#435)
@gmaclennan gmaclennan mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a default offline map in app
2 participants