Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add 32-bit builds #311

Closed
wants to merge 31 commits into from
Closed

fix: add 32-bit builds #311

wants to merge 31 commits into from

Conversation

okdistribute
Copy link
Contributor

@okdistribute okdistribute commented Mar 18, 2020

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations. Please submit translation changes via our Mapeo Crowdin project
  • My commits are in nice logical chunks with good commit messages
  • I have walked through the QA Manual Testing
    Script
    and updated it if necessary.
  • If my changes depend upon an update to a dependency, I have updated the package-lock.json file using npm install --package-lock
  • My changes have been tested with the mobile app.
  • My changes are ready to be shipped to users on Windows, Mac, and Linux

Description

Fixes #305, although it means that 32-bit machines will need to download the appropriate installer which can be a bit annoying. Perhaps we can detect this in the mapeo.world website

@okdistribute
Copy link
Contributor Author

Once Level/leveldown#711 is merged, 32 bit builds should work. We won't need this

@okdistribute okdistribute deleted the 32bit-builds branch March 25, 2020 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapeo Desktop Installer doesn't run on 32bit machines
1 participant