fix: only the project creator can change their role #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(This diff looks large, but it's just one line of source code and a
bunch of tests.)
We have some code like this:
```
if (isAssigningProjectCreatorRole && !this.#isProjectCreator()) {
```
The intent: only allow the project creator to change their own role.
However, `this.#isProjectCreator` returned a `Promise`, which meant that
the second part of the condition *always* evaluated to `false`, which
meant that the whole condition always evaluated to false, which meant
that non-creators could change the creator's role.
This fixes that by making `#isProjectCreator` return a `boolean`, not
`Promise<boolean>`.
Found this while working on [#188].
[#188]: #188
gmaclennan
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This diff looks large, but it's just one line of source code and a bunch of tests.)
We have some code like this:
The intent: only allow the project creator to change their own role.
However,
this.#isProjectCreatorreturned aPromise, which meant that the second part of the condition always evaluated tofalse, which meant that the whole condition always evaluated to false, which meant that non-creators could change the creator's role.This fixes that by making
#isProjectCreatorreturn aboolean, notPromise<boolean>.Found this while working on #188.