chore: add omit utility
#909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should have no impact on functionality.
This replaces the following pattern:
```javascript
// eslint-disable-next-line no-unused-vars
const { foo, bar, ...rest } = obj
return rest
```
With a new `omit` utility, which I think is clearer:
```javascript
return omit(obj, ['foo', 'bar'])
```
I think this is a useful change on its own, but also makes an upcoming
change slightly easier because I wanted this function.
EvanHahn
commented
Oct 17, 2024
achou11
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
lgtm! seeing this reminds me of https://github.com/toss/es-toolkit, which maybe isn't necessary for us anytime soon, but could be worth considering if we keep adding things like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not urgent.
This change should have no impact on functionality.
This replaces the following pattern:
With a new
omitutility, which I think is clearer:I think this is a useful change on its own, but also makes an upcoming change slightly easier because I wanted this function.