-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: persist cores #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks cool!
The only thing I was confused by was moving the CREATE_SQL
and addCoreSqlStmt
to core-manager/index.js. It seemed like having them in core-index.js was a good separation. Not really a big deal though if the CoreIndex class is internal to CoreManager.
Yeah, I did not like that either. Because events need to be added to cores loaded from persistence (which happens in the parent class) it became a very leaky abstraction to keep the persistence in the index. Couldn't figure out a neat way to separate it, but yeah, it's not pretty but it works |
Persist cores that are added to the core manager. Fixes #86
Todo: