fix: update pre-haves as they change #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the following scenario: 1. Alice and Bob connect but do not start sync. 2. Alice adds an observation. Bob should see that there is something new to sync. Previously, this wouldn't happen. Now, when a writer core is appended to or cleared, we send new pre-have messages. Closes [#582]. [#582]: #582
EvanHahn
commented
Apr 30, 2024
Comment on lines
-307
to
-311
| // A non-writer core will emit 'append' when its length is updated from the | ||
| // initial sync with a peer, and we will not have sent a "maybe want" for | ||
| // this range, so we need to do it now. Subsequent appends are propogated | ||
| // (more efficiently) via range broadcasts, so we only need to listen to the | ||
| // first append. |
There was a problem hiding this comment.
I moved this comment down and re-formatted it so no line was longer than 80 characters; I didn't change it other than fixing a typo.
Comment on lines
+318
to
+323
| const originalClear = core.clear | ||
| core.clear = function clear() { | ||
| const result = originalClear.apply(this, /** @type {any} */ (arguments)) | ||
| result.then(sendHaves) | ||
| return result | ||
| } |
There was a problem hiding this comment.
I considered patching Hypercore itself, which doesn't feel meaningfully different. I don't think Hypercore offers a way to address this in a better way, even on newer versions.
|
Merging without review. I'll ask @gmaclennan to review soon. |
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following scenario:
Bob should see that there is something new to sync.
Previously, this wouldn't happen. Now, when a writer core is appended to or cleared, we send new pre-have messages.
Closes #582.