-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add additional jsdoc annotations for discovery module #30
Conversation
2b77486
to
2642c46
Compare
@sethvincent working through adding examples and a couple of questions come up:
|
lib/discovery/index.js
Outdated
* | ||
* ```js | ||
* | ||
* // Create identities... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be useful to list relevant methods for creating identities here and maybe link to their spot in the docs (not sure off the top of my head if that's possible from within example code using typedoc, so maybe this note would be outside the code block).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah makes sense! Another idea: not sure how it would look in the generated output but could put a (collapsible?) snippet for an example of creating the identity, as a footnote type of thing that can be referenced from here. Maybe too complicated so probably stick with your idea
Yeah only public methods. I think we should lean toward minimal examples as much as possible. The examples you've added so far look pretty good to me. I just added one comment about referencing/linking to related methods that would add too much boilerplate in a method's example. |
Addresses #20
So far:
What's left:
descriptions about classesexample annotations