Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose capabilities in MapeoProject and its member api #286

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Sep 27, 2023

Closes #239

Exposes capabilities in the following ways:

  • adds a $getOwnCapabilities() method to MapeoProject
  • adds a capabilities field to the return value of project.$member.getById() and project.$member.getMany()

TODO:

  • Feel like some of the tests belong in e2e but not sure if that's blocked on the invites stuff
    • the e2e capabilities tests should ideally be able to use project.$member to retrieve the capabilities. currently relies on Save relevant device info when initially creating/adding a project #289 and updating the MemberApi.invite() implementation
    • the e2e manager invite tests should check that the inviter can retrieve the member's device info using the member api after the invite is accepted
  • still wondering what the best way to get your own capabilities for a project is. basically, should there be a project.$getOwnCapabilities() method?
    • Update tests to account for this method

@achou11 achou11 self-assigned this Sep 27, 2023
@achou11 achou11 changed the title feat: include capabilities in MemberApi return types feat: expose capabilities using MapeoProject Sep 27, 2023
@achou11 achou11 changed the title feat: expose capabilities using MapeoProject feat: expose capabilities in MapeoProject and its member api Oct 2, 2023
@achou11 achou11 marked this pull request as ready for review October 2, 2023 18:45
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think we can sort out the e2e tests once we have some of the other things in place.

Reviewing this I realized that we need to tweak a couple of other things, which I have opened issues for:

@achou11 achou11 merged commit 1e98363 into main Oct 3, 2023
5 of 6 checks passed
@achou11 achou11 deleted the 239/expose-capabilities branch October 3, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose "ownCapabilities"
2 participants