-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose capabilities in MapeoProject and its member api #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
changed the title
feat: include capabilities in MemberApi return types
feat: expose capabilities using MapeoProject
Sep 27, 2023
achou11
force-pushed
the
239/expose-capabilities
branch
from
September 28, 2023 18:35
bdd62c4
to
238373e
Compare
achou11
force-pushed
the
239/expose-capabilities
branch
from
September 28, 2023 20:42
238373e
to
77352f5
Compare
achou11
force-pushed
the
239/expose-capabilities
branch
from
October 2, 2023 18:12
77352f5
to
ade1c7d
Compare
achou11
changed the title
feat: expose capabilities using MapeoProject
feat: expose capabilities in MapeoProject and its member api
Oct 2, 2023
gmaclennan
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think we can sort out the e2e tests once we have some of the other things in place.
Reviewing this I realized that we need to tweak a couple of other things, which I have opened issues for:
tomasciccola
pushed a commit
that referenced
this pull request
Oct 3, 2023
This was referenced Nov 16, 2023
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #239
Exposes capabilities in the following ways:
$getOwnCapabilities()
method toMapeoProject
capabilities
field to the return value ofproject.$member.getById()
andproject.$member.getMany()
TODO:
project.$member
to retrieve the capabilities. currently relies on Save relevant device info when initially creating/adding a project #289 and updating theMemberApi.invite()
implementationproject.$getOwnCapabilities()
method?