Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getMany method to member api #263

Merged
merged 2 commits into from
Sep 18, 2023
Merged

feat: add getMany method to member api #263

merged 2 commits into from
Sep 18, 2023

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Sep 12, 2023

Closes #257

Currently stacked on #262

Lacking some tests as I intend to write more e2e once more methods are implemented

Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to fix merge issues - I think #262 doesn't have main merged, but this one does.

Base automatically changed from 256/member-get-by-id to main September 18, 2023 15:12
@achou11 achou11 merged commit 350ccc5 into main Sep 18, 2023
6 checks passed
@achou11 achou11 deleted the 257/member-get-many branch September 18, 2023 15:23
gmaclennan added a commit that referenced this pull request Sep 19, 2023
* main:
  chore: condense setup code in MemberAPI tests (#267)
  chore: replace queries opt in MemberAPI with dataType (#266)
  feat: add getMany method to member api (#263)
  feat: add getById method to member api (#262)
  chore: Update @digidem/types and remove patch (#269)
  feat: share all core keys via extension messages (#264)
  feat: send core "haves" bitfield on first connect (#254)
  fix: invite.encryptionKeys should be required (#260)
  feat: Add set & get deviceInfo & datatype (#250)
  expose member namespace in MapeoProject (#253)
  blobStore.createReadStream should not wait (#243)
  update MapeoManager to return and handle project public IDs (#247)
  return content hash from blobApi.create (#242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement member.getMany() method in the MemberApi
2 participants