feat: handle coreOwnership records in IndexWriter [1/3]
#214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmaclennan
force-pushed
the
feat/core-ownership-index-writer
branch
2 times, most recently
from
b120309
to
97b51e4
Compare
gmaclennan
changed the title
coreOwnership records to IndexWritercoreOwnership records in IndexWriter [1/3]
7 tasks
achou11
reviewed
Aug 28, 2023
gmaclennan
force-pushed
the
feat/core-ownership-index-writer
branch
from
97b51e4
to
c4688cf
Compare
custom getWinner and initial mapDoc Add verifyCoreOwnership function Add mapAndValidateCoreOwnership move some code around add mapDoc and getWinner options to indexWriter Add tests & small fix Fix types and use defaultGetWinner from @mapeo/sqlite-indexer WIP add coreOwnership custom getWinner and initial mapDoc Add verifyCoreOwnership function Add mapAndValidateCoreOwnership move some code around add mapDoc and getWinner options to indexWriter Add tests & small fix Fix types and use defaultGetWinner from @mapeo/sqlite-indexer
gmaclennan
force-pushed
the
feat/core-ownership-index-writer
branch
from
c4688cf
to
d815ca4
Compare
gmaclennan
added a commit
that referenced
this pull request
Sep 6, 2023
* main: (25 commits) add initial implementation of MemberApi (#232) feat: $blobs.getUrl and $blobs.create methods (#184) chore: update manager e2e tests (#237) feat: add capabilities (#231) feat: coreOwnership integration [3/3] (#230) feat: CoreOwnership class w getOwner & getCoreKey [2/3] (#229) feat: handle `coreOwnership` records in `IndexWriter` [1/3] (#214) fix: adjust storage options for MapeoManager and MapeoProject (#235) implement addProject method for MapeoManager class (#215) implement listProjects method for MapeoManager class (#208) feat: expose blobStore.writerDriveId (#219) implement wrapper client containing createProject and getProject methods (#199) add project settings functionality to MapeoProject (#187) feat: Add encode/decode for project keys [3/3] (#203) feat: update protobuf for RPC [2/3] (#202) chore: move protobuf messages into src/generated [1/3] (#201) feat: Add internal `dataType.createWithDocId()` (#192) chore: explicitly set "mode" opt for encryptionKeys column creation (#186) chore: fix linting and type checking (#183) chore: consolidate encryption key columns in projectKeys table (#181) ...
This was referenced Nov 16, 2023
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210, see issue for description
[]which makes every document a fork, causing the indexer to callgetWinner()to determine which document to index.getWinner()function for always choosing the first core ownership record