chore: code cleanup and re-org #154
Conversation
- Remove code replaced by new DataStore, DataType and IndexWriter implementations - Skip failing tests for now - Move all code to `src` folder to prepare for compiling typescript declaration files for package publishing
There was a problem hiding this comment.
Couple of minor questions but otherwise lgtm!
Didn't want to comment on all potentially generated files, but would be helpful to have first-line comments for those files to indicate that they're generated, so we don't accidentally attempt to manually update them in the future
There was a problem hiding this comment.
is this a generated file? if so, is there a way to add a comment here to indicate that?
There was a problem hiding this comment.
Yes. Not sure. Let's address in a separate issue (this PR doesn't change this file)
There was a problem hiding this comment.
would test.todo be more appropriate for these or does it not really matter?
There was a problem hiding this comment.
I'll just remember for now, will be working on this next week.
* main: chore: remove todo comments (#159)
implementations
srcfolder to prepare for compiling typescriptdeclaration files for package publishing
Why move everything into
src? For publishing we need to compile Typescript declarations (.d.ts). It's difficult to manage outputting these alongside the source files, it's easier to manage if all declarations go in adistfolder. However if there are JS files that need type-checked in the top-level project folder, then Typescript config can be a pain. Typescript is easiest to configure when all code that needs to be compiled is in a single folder, for whichsrcmakes the most sense.