Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Issue license to holder #4

Merged
merged 8 commits into from
Mar 28, 2022
Merged

Issue license to holder #4

merged 8 commits into from
Mar 28, 2022

Conversation

jonmattgray
Copy link
Contributor

@jonmattgray jonmattgray commented Mar 22, 2022

  • Create a license credential definition if one doesn't exist
  • Listens for license presentation proof proposals from a holder
  • Send a presentation proof to holder upon receiving a proposal. Deletes the proposal
  • Issues licenses for verified proofs (proof presentation and verification happens automatically with ACAPY_AUTO_ envs on cloudagents). Deletes proof record

@jonmattgray jonmattgray force-pushed the feat/issue-license branch 4 times, most recently from b745a70 to e0fb69b Compare March 24, 2022 12:33
@jonmattgray jonmattgray marked this pull request as ready for review March 24, 2022 17:57
Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make some further improvements on the flow here. There's a bunch of logic happening across components which I'm not wild about. Let me know if you want to talk it through

Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking much better. There's still a bit more cleanup that I'll pickup today @jonmattgray.

package.json Outdated Show resolved Hide resolved
src/interface/hooks/use-issue-license.js Show resolved Hide resolved
src/interface/hooks/use-issue-license.js Show resolved Hide resolved
src/interface/hooks/use-post-credential-definitions.js Outdated Show resolved Hide resolved
src/interface/hooks/use-post-credential-definitions.js Outdated Show resolved Hide resolved
src/interface/hooks/use-post-present-proof-send-request.js Outdated Show resolved Hide resolved
src/interface/hooks/use-post-present-proof-send-request.js Outdated Show resolved Hide resolved
src/interface/hooks/use-post-schemas.js Outdated Show resolved Hide resolved
Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but since I'm a co-author waiting for approval from @n3op2 before merging

@mattdean-digicatapult mattdean-digicatapult merged commit 9a2828c into main Mar 28, 2022
@mattdean-digicatapult mattdean-digicatapult deleted the feat/issue-license branch March 28, 2022 12:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants