Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement/IISCRUM-1249 #5

Merged
merged 9 commits into from
Jun 5, 2020
Merged

Conversation

timyllym
Copy link

@timyllym timyllym commented Jun 4, 2020

Update Iiris changes to release-3.11.0 branch

@timyllym timyllym requested a review from sapajune June 4, 2020 09:44
Copy link

@sapajune sapajune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

dark: 'plugins/alexanderzobnin-zabbix-app/css/grafana-zabbix.dark.css',
light: 'plugins/alexanderzobnin-zabbix-app/css/grafana-zabbix.light.css'
dark: 'plugins/iiris-zabbix-triggers-panel/css/grafana-zabbix.dark.css',
light: 'plugins/iiris-zabbix-triggers-panel/css/grafana-zabbix.light.css'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path seems a bit weird.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path should be ok. But something else is wrong anyway, I just tried and the datasource doesn't work.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just referring to "triggers-panel" - seems to me this more global css than that. 😄

@timyllym timyllym merged commit 576fb0d into iiris-release-3.11.0 Jun 5, 2020
@timyllym timyllym deleted the improvement/IISCRUM-1249 branch June 5, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants