Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support digits in atoms #32

Closed
wants to merge 1 commit into from
Closed

Conversation

lgalarra
Copy link
Collaborator

I have modified the regex that parses terms in atoms to support digits.

@lgalarra lgalarra requested a review from lajus July 16, 2020 14:53
@lajus
Copy link
Contributor

lajus commented Jul 17, 2020

Hi,

I already pushed the change long time ago (adding \w instead of \d) cf issue #21.

Jonathan

@lgalarra
Copy link
Collaborator Author

Hi Jonathan,

I do not understand, I thought \w does not match digits. Without those changes AMIE cannot parse the following rule mined from Freebase (because of the digits in the predicate):

?a /location/statistical_region/rent50_1./measurement_unit/dated_money_value/currency ?b => ?a /location/statistical_region/rent50_2./measurement_unit/dated_money_value/currency

Cheers,
Luis

@lajus
Copy link
Contributor

lajus commented Jul 17, 2020

Hi,

It does: https://www.w3schools.com/jsref/jsref_regexp_wordchar.asp

If you pull the master branch there should be no problem parsing those predicates.

Jonathan

@lajus lajus closed this Jul 17, 2020
@lgalarra
Copy link
Collaborator Author

I see! I was confused by the \p{L}, which allows us to match non-ascii letters. I will then get the code from the master branch. Thanks and sorry for the false alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants