Head coverage bug + regex bug in KB #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2020
lajus
approved these changes
Jun 4, 2020
lajus
pushed a commit
that referenced
this pull request
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jonathan,
I am creating a pull request with a couple of fixes. Precisely: head coverage threshold is not applied when it is explicitly stated, i.e., -minhc X is part of the parameters list. Also the method KB.rules() was not able to parse rules of the form:
?a /film/actor/film./film/performance/film /m/0340hj => ?a neg_/award/award_nominee/award_nominations./award/award_nomination/award /m/02x8n1n
so I modified the parsing in KB.java. Please, have a look at it whenever you have time. Thanks for the hard work!
Best,
Luis