Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temporary workspace deletion on JVM shutdown (#967) #971

Merged
merged 1 commit into from
Oct 24, 2021
Merged

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Oct 17, 2021

Applies 42ffbe9 and 49b3e3e, which fixes #967 to all Eclipse formatters using spotless-eclipse.base:3.5.x. Back port for spotless-eclipse.base:3.4.x (JVM 8) is not planned.

@fvgh fvgh marked this pull request as draft October 17, 2021 11:16
@nedtwigg
Copy link
Member

Is this a draft on purpose? LGTM, feel free to merge.

@fvgh
Copy link
Member Author

fvgh commented Oct 20, 2021

@nedtwigg As stated in the PRs description, I am afraid com.diffplug.spotless:spotless-eclipse-base:3.5.1 did not finally solve #967. I'll have another look...

@fvgh fvgh marked this pull request as ready for review October 24, 2021 08:12
@fvgh fvgh merged commit 2e61129 into main Oct 24, 2021
@fvgh fvgh deleted the fix_967 branch October 24, 2021 08:22
@nedtwigg
Copy link
Member

Released in plugin-gradle 5.17.1 and plugin-maven 2.17.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Could not write workspace metadata '/tmp/com_diffplug_spotless_extra_eclipse
2 participants