Add groovy formatter to maven

[bitwiseman]

After creating the PR, please add a commit that adds a bullet-point under the -SNAPSHOT section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

• a summary of the change
• either
  • a link to the issue you are resolving (for small changes)
  • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and the build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

[nedtwigg]

Thanks for a great PR, looks good. The way that the README works is not intuitive, you edited the top part correctly, but you needed to run spotlessApply so that it would render into the actual markdown. I also added docs by copying the equivalent docs from gradle.

In the Gradle plugin, we call this step greclipse. I think it's confusing to have two steps with the same name (two different Eclipse classes in the maven plugin). We should either rename it to Greclipse or GroovyEclipse, no preference from me.

[bitwiseman]

@nedtwigg
Thanks! I updated it to greclipse.

[bitwiseman]

It looks like your checks are not behaving well. Should this say "All checks have passed" when only one check has run?

[nedtwigg]

Nope, it shouldn't. CircleCI is having issues :(

• https://app.circleci.com/pipelines/github/diffplug/spotless?branch=pull%2F697
• https://status.circleci.com/

I'm gonna let this rest for 24 hours in case other maintainers have comments. Once that 24 hrs has passed and our CI providers comes back online, we'll merge and release.

[bitwiseman]

@nedtwigg
Do have you added all the checks to the required checks list for the main branch? (Just to make sure no one accidentally merges when not all checks have run.)

[nedtwigg]

Yes, CircleCI is just down today is all. Bummer that it fails danger, rather than safe. I'll figure out CI tonight, I don't wanna spend time on it while it's still flaky.

[nedtwigg]

CI is fixed now. I'll merge and release tomorrow, barring any objections.

[nedtwigg]

Released in plugin-maven 2.4.0.