Fix Eclipse WTP encoding handling #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spotless always provides decoded string to WTP.
|
There could be further investigation in how far other formatters are affected by the content descriptors. |
nedtwigg
reviewed
Mar 24, 2020
...clipse-wtp/src/main/java/com/diffplug/spotless/extra/eclipse/wtp/sse/ContentTypeManager.java
Outdated
Show resolved
Hide resolved
nedtwigg
requested changes
Mar 26, 2020
|
Sorry, need to have another look... Am afraid I never used encoding in depth when working with Java. Find the function description partly misleading. |
Java strings are always "decoded" (as UTF-16). This internal code format is transparent to all interfaces. Encodings/Decodings to/from other formats are only accomplished on byte arrays/streams.
|
The fix looks great, thanks! |
|
I merged to publish, but made a few changes on master before publishing: eclipse-wtp 3.15.3 is now available on bintray/jcenter, but it is not available on mavencentral. I'm not able to sync, and not sure why. Hopefully it is a transient, I'll try again later today. |
|
the mavencentral sync has magically resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the WTP encoding handling.
Spotless always provides decoded string to WTP.
The original implementation did not provide any coding descriptions. Hence for HTML, the platform specific one were used. E.g. this affects all WTP clean-up tasks, not only HTML, but whether the others do a second decoding in the first place, has not been checked thoroughly.
Probably they do not.
Anyhow, the changed implementation assures that this part of the code common to all WTP formatters, behaves like that original WTP, though the input files are not directly accessed.