Spotless Eclipse Framework Final #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Eclipse based formatters.
Eclipse core uses plugins not derived from Plugin but BundleActivator. Provided possibility to configure global preferences. Usage of Consumer allows the user to get rid of statics.
This improves the development of Eclipse formatters.
Enhanced BundleController by creating separate class for SimpleBundel (previously called SystemBundle). Added support for plugins offering headless builds.
Applied changes requested by review (@JLLeitschuh).
…implementations in dependencies.
…t (see #1262). Removed model space to allow local publishing of releases.
|
@nedtwigg Had a final test of the conflicts solved manually within this PR. The branch is in line with my local one. So I am ready to merge. |
|
Hmm, I tried to publish, but I'm getting a build error: I'll push my config up as a PR. |
|
Oh, sorry, I think I realized my misunderstanding. This branch needs to be merged first? And then I publish |
|
Ahh yes, sorry, just catching up on the thread. I see that you've prepped this branch for publishing (like you said, the PR's are being presented in a weird way). I'm merging this and publishing! |
|
@nedtwigg Thanks! |
|
Okay! The package is published to bintray: https://bintray.com/diffplug/opensource/spotless-eclipse-base I asked bintray to publish this to jcenter, which requires manual approval from them. Once they've approved it, I'll be able to sync to mavencentral, and we'll have a publishing pipeline for this. I'm headed to bed, but I expect we'll get approved sometime tomorrow. Great work @fvgh, very excited to have this land to users soon :) |
|
Now available in jcenter and mavencentral as |
|
@nedtwigg Thanks for adding the sources o the publication. Just remembered it after I saw your notification that you published 😄 Thought that I have to live without sources fro this version. Feel free to continue with JDT/Groovy. |
|
Great!
Just FYI, I got some warnings/errors in compiling eclipse-groovy: |
|
|
|
@nedtwigg About the errors/warnings: I hat the problem already in #13 . As we discussed, I have not really an idea how P2 works. This time it additionally complains about dependencies provided already by
😃 |
|
I only wanted to bring it up in case the version I published had a different set of warnings than you expected. I don't anticipate any problems, but if you encounter any surprises while closing this out, it might be a place to look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for final version 3.0.0 (Commits on Jul 14, 2018) were not considered by #234.