Make version compatibility tasks workable #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
commented
Jan 24, 2023
Comment on lines
+45
to
+48
| tasks.named("check").configure { | ||
| dependsOn(tasks.named("testCompatibilityAdapters")) | ||
| dependsOn(tasks.named("testCompatibility")) | ||
| } |
There was a problem hiding this comment.
Comment on lines
+122
to
+137
| tasks.withType(Test).configureEach { | ||
| def jdkVersion = JavaVersion.current().majorVersion.toInteger() | ||
| def args = [] | ||
| if (jdkVersion >= 16) { | ||
| // https://docs.gradle.org/7.5/userguide/upgrading_version_7.html#removes_implicit_add_opens_for_test_workers | ||
| args += [ | ||
| "--add-opens=java.base/java.lang=ALL-UNNAMED", | ||
| "--add-opens=java.base/java.util=ALL-UNNAMED", | ||
| ] | ||
| } | ||
| if (jdkVersion >= 18) { | ||
| // https://openjdk.org/jeps/411 | ||
| args += "-Djava.security.manager=allow" | ||
| } | ||
| jvmArgs(args) | ||
| } |
There was a problem hiding this comment.
Run ./gradlew :lib:testCompatKtLint0Dot48Dot0
> Task :lib:testCompatKtLint0Dot48Dot0 FAILED
com.diffplug.spotless.glue.ktlint.compat.KtLintCompat0Dot48Dot0AdapterTest
Test testEditorConfigCanDisable(Path) PASSED
Test testDefaults(Path) FAILED
java.lang.ExceptionInInitializerError
at com.diffplug.spotless.glue.ktlint.compat.KtLintCompat0Dot48Dot0AdapterTest.testDefaults(KtLintCompat0Dot48Dot0AdapterTest.java:43)
Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field private transient java.lang.Object java.lang.Throwable.backtrace accessible: module java.base does not "opens java.lang" to unnamed module @689349f1
at com.diffplug.spotless.glue.ktlint.compat.KtLintCompat0Dot48Dot0AdapterTest.testDefaults(KtLintCompat0Dot48Dot0AdapterTest.java:43)
FAILURE: Executed 2 tests in 1s (1 failed)
Goooler
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1502 (comment).