Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be able to do inline assertions on facets too. There are a few subtleties here worth mentioning:
expectSelfie(blah).facet("md").toBe("blah blah")
is pretty straightforwardexpectSelfie(blah).facets("links", "md").toBe...
is also straightforward, but with a twist, we need to do the escaping from a SnapshotFile so that the facets are unambiguous from each other:"md", "links"
, the order the facets are printed should be swapped╔═ ═╗
(weird) or nothing. With the one odd side effect that we are sort of requiring the root snapshot to be first in the list, which is okay.Right now, we have one constraint which is that the facets must be displayed in alpha order, because we don't have access to SnapshotFile's internals, and it always sorts its keys. To fix this, we'll need to move the Selfie API into the common project, which is already a good idea for other reasons.